Title: [259549] trunk/Source/_javascript_Core
Revision
259549
Author
[email protected]
Date
2020-04-05 01:59:57 -0700 (Sun, 05 Apr 2020)

Log Message

[JSC] JSArrayIterator's size is wrong
https://bugs.webkit.org/show_bug.cgi?id=210020

Reviewed by Mark Lam.

Internal-size of JSArrayIterator should be 3, not 4.

* runtime/JSArrayIterator.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (259548 => 259549)


--- trunk/Source/_javascript_Core/ChangeLog	2020-04-05 08:41:26 UTC (rev 259548)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-04-05 08:59:57 UTC (rev 259549)
@@ -1,3 +1,14 @@
+2020-04-05  Yusuke Suzuki  <[email protected]>
+
+        [JSC] JSArrayIterator's size is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=210020
+
+        Reviewed by Mark Lam.
+
+        Internal-size of JSArrayIterator should be 3, not 4.
+
+        * runtime/JSArrayIterator.h:
+
 2020-04-05  Mark Lam  <[email protected]>
 
         Rolling out r259545: causing CodeSigning error in jsc EWS bot.

Modified: trunk/Source/_javascript_Core/runtime/JSArrayIterator.h (259548 => 259549)


--- trunk/Source/_javascript_Core/runtime/JSArrayIterator.h	2020-04-05 08:41:26 UTC (rev 259548)
+++ trunk/Source/_javascript_Core/runtime/JSArrayIterator.h	2020-04-05 08:59:57 UTC (rev 259549)
@@ -29,15 +29,16 @@
 
 namespace JSC {
 
-class JSArrayIterator final : public JSInternalFieldObjectImpl<4> {
+class JSArrayIterator final : public JSInternalFieldObjectImpl<3> {
 public:
-    using Base = JSInternalFieldObjectImpl<4>;
+    using Base = JSInternalFieldObjectImpl<3>;
 
-    enum class Field : uint8_t { 
+    enum class Field : uint8_t {
         Index = 0,
         IteratedObject,
         Kind,
     };
+    static_assert(numberOfInternalFields == 3);
 
     static size_t allocationSize(Checked<size_t> inlineCapacity)
     {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to