Title: [252799] trunk/Source/WebInspectorUI
Revision
252799
Author
drou...@apple.com
Date
2019-11-22 13:58:08 -0800 (Fri, 22 Nov 2019)

Log Message

Web Inspector: REGRESSION(r251227): dashboard no longer shows page weight
https://bugs.webkit.org/show_bug.cgi?id=204528

Reviewed by Brian Burg.

`WI.contentLoaded` adds the debuggable type as a class to the `<body>`. In r251227, the
"web" debuggable type was split into "page" and "web-page". Update the few selectors that
used the debuggable type to show/hide parts of the UI.

* UserInterface/Views/DashboardContainerView.css:
(body:matches(.page, .web-page) .toolbar .dashboard-container): Added.
(body:not(.page, .web-page) .toolbar .dashboard-container): Added.
(body.web .toolbar .dashboard-container): Deleted.
(body:not(.web) .toolbar .dashboard-container): Deleted.
* UserInterface/Views/DefaultDashboardView.css:
(body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Added.
(body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Added.
(body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Deleted.
(body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (252798 => 252799)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-11-22 21:32:18 UTC (rev 252798)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-11-22 21:58:08 UTC (rev 252799)
@@ -1,3 +1,25 @@
+2019-11-22  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: REGRESSION(r251227): dashboard no longer shows page weight
+        https://bugs.webkit.org/show_bug.cgi?id=204528
+
+        Reviewed by Brian Burg.
+
+        `WI.contentLoaded` adds the debuggable type as a class to the `<body>`. In r251227, the
+        "web" debuggable type was split into "page" and "web-page". Update the few selectors that
+        used the debuggable type to show/hide parts of the UI.
+
+        * UserInterface/Views/DashboardContainerView.css:
+        (body:matches(.page, .web-page) .toolbar .dashboard-container): Added.
+        (body:not(.page, .web-page) .toolbar .dashboard-container): Added.
+        (body.web .toolbar .dashboard-container): Deleted.
+        (body:not(.web) .toolbar .dashboard-container): Deleted.
+        * UserInterface/Views/DefaultDashboardView.css:
+        (body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Added.
+        (body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Added.
+        (body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs)): Deleted.
+        (body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time)): Deleted.
+
 2019-11-20  Brian Burg  <bb...@apple.com>
 
         Web Inspector: add support for new kinds of diagnostic events

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (252798 => 252799)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2019-11-22 21:32:18 UTC (rev 252798)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css	2019-11-22 21:58:08 UTC (rev 252799)
@@ -32,12 +32,12 @@
     overflow: hidden;
 }
 
-body.web .toolbar .dashboard-container {
+body:matches(.page, .web-page) .toolbar .dashboard-container {
     width: 36vw;
     min-width: 350px;
 }
 
-body:not(.web) .toolbar .dashboard-container {
+body:not(.page, .web-page) .toolbar .dashboard-container {
     width: 25vw;
     min-width: 175px;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css (252798 => 252799)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2019-11-22 21:32:18 UTC (rev 252798)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css	2019-11-22 21:58:08 UTC (rev 252799)
@@ -23,11 +23,11 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-body.web .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs) {
+body:matches(.page, .web-page) .toolbar.collapsed .dashboard.default > :matches(.resourcesSize, .time, .logs) {
     display: none;
 }
 
-body:not(.web) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time) {
+body:not(.page, .web-page) .toolbar .dashboard.default > :matches(.resourcesCount, .resourcesSize, .time) {
     display: none;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to