Title: [103261] trunk/Tools
- Revision
- 103261
- Author
- dpra...@chromium.org
- Date
- 2011-12-19 13:28:51 -0800 (Mon, 19 Dec 2011)
Log Message
webkitpy: remove executive,filesystem,user parameters from Port constructor
https://bugs.webkit.org/show_bug.cgi?id=74878
Reviewed by Eric Seidel.
This change concludes the refactoring that makes Host a required
parameter for Port and ensures that all access to filesystem,
executives, etc. is going through the Host.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (103260 => 103261)
--- trunk/Tools/ChangeLog 2011-12-19 21:16:33 UTC (rev 103260)
+++ trunk/Tools/ChangeLog 2011-12-19 21:28:51 UTC (rev 103261)
@@ -1,5 +1,19 @@
2011-12-19 Dirk Pranke <dpra...@chromium.org>
+ webkitpy: remove executive,filesystem,user parameters from Port constructor
+ https://bugs.webkit.org/show_bug.cgi?id=74878
+
+ Reviewed by Eric Seidel.
+
+ This change concludes the refactoring that makes Host a required
+ parameter for Port and ensures that all access to filesystem,
+ executives, etc. is going through the Host.
+
+ * Scripts/webkitpy/layout_tests/port/base.py:
+ (Port.__init__):
+
+2011-12-19 Dirk Pranke <dpra...@chromium.org>
+
webkitpy: finish refactoring port classes to make a host mandatory
https://bugs.webkit.org/show_bug.cgi?id=74566
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (103260 => 103261)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-12-19 21:16:33 UTC (rev 103260)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-12-19 21:28:51 UTC (rev 103261)
@@ -88,13 +88,7 @@
ALL_BUILD_TYPES = ('debug', 'release')
- def __init__(self, host,
- port_name=None, options=None,
- executive=None,
- user=None,
- filesystem=None,
- config=None,
- **kwargs):
+ def __init__(self, host, port_name=None, options=None, config=None, **kwargs):
# These are default values that should be overridden in a subclasses.
self._name = port_name or self.port_name # Subclasses may append a -VERSION (like mac-leopard) or other qualifiers.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
