Title: [103224] trunk/Source/WebCore
- Revision
- 103224
- Author
- [email protected]
- Date
- 2011-12-19 00:48:51 -0800 (Mon, 19 Dec 2011)
Log Message
Remove unnecessary [JSCCustomGetter] IDLs from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=74829
Reviewed by Adam Barth.
Now JSC has implemented the [Constructor] IDL and it generates
getDOMConstructor() automatically. This patch removes hand-written
unnecessary getDOMConstructor()s from JSDOMWindowCustom.cpp.
No new tests. No change in behavior.
* bindings/js/JSDOMWindowCustom.cpp:
* page/DOMWindow.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (103223 => 103224)
--- trunk/Source/WebCore/ChangeLog 2011-12-19 08:28:06 UTC (rev 103223)
+++ trunk/Source/WebCore/ChangeLog 2011-12-19 08:48:51 UTC (rev 103224)
@@ -1,3 +1,19 @@
+2011-12-19 Kentaro Hara <[email protected]>
+
+ Remove unnecessary [JSCCustomGetter] IDLs from DOMWindow.idl
+ https://bugs.webkit.org/show_bug.cgi?id=74829
+
+ Reviewed by Adam Barth.
+
+ Now JSC has implemented the [Constructor] IDL and it generates
+ getDOMConstructor() automatically. This patch removes hand-written
+ unnecessary getDOMConstructor()s from JSDOMWindowCustom.cpp.
+
+ No new tests. No change in behavior.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * page/DOMWindow.idl:
+
2011-12-19 Adam Barth <[email protected]>
The HTML parser doesn't enforce the "Noah's Ark condition" from the HTML5 spec
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (103223 => 103224)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-12-19 08:28:06 UTC (rev 103223)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-12-19 08:48:51 UTC (rev 103224)
@@ -476,11 +476,6 @@
return toJS(exec, const_cast<JSDOMWindow*>(this), event);
}
-JSValue JSDOMWindow::eventSource(ExecState* exec) const
-{
- return getDOMConstructor<JSEventSourceConstructor>(exec, this);
-}
-
JSValue JSDOMWindow::image(ExecState* exec) const
{
return getDOMConstructor<JSImageConstructor>(exec, this);
@@ -500,92 +495,6 @@
}
#endif
-JSValue JSDOMWindow::webKitPoint(ExecState* exec) const
-{
- return getDOMConstructor<JSWebKitPointConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::webKitCSSMatrix(ExecState* exec) const
-{
- return getDOMConstructor<JSWebKitCSSMatrixConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::arrayBuffer(ExecState* exec) const
-{
- return getDOMConstructor<JSArrayBufferConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::int8Array(ExecState* exec) const
-{
- return getDOMConstructor<JSInt8ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::uint8Array(ExecState* exec) const
-{
- return getDOMConstructor<JSUint8ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::int32Array(ExecState* exec) const
-{
- return getDOMConstructor<JSInt32ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::uint32Array(ExecState* exec) const
-{
- return getDOMConstructor<JSUint32ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::int16Array(ExecState* exec) const
-{
- return getDOMConstructor<JSInt16ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::uint16Array(ExecState* exec) const
-{
- return getDOMConstructor<JSUint16ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::float32Array(ExecState* exec) const
-{
- return getDOMConstructor<JSFloat32ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::float64Array(ExecState* exec) const
-{
- return getDOMConstructor<JSFloat64ArrayConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::dataView(ExecState* exec) const
-{
- return getDOMConstructor<JSDataViewConstructor>(exec, this);
-}
-
-JSValue JSDOMWindow::xmlHttpRequest(ExecState* exec) const
-{
- return getDOMConstructor<JSXMLHttpRequestConstructor>(exec, this);
-}
-
-#if ENABLE(XSLT)
-JSValue JSDOMWindow::xsltProcessor(ExecState* exec) const
-{
- return getDOMConstructor<JSXSLTProcessorConstructor>(exec, this);
-}
-#endif
-
-#if ENABLE(CHANNEL_MESSAGING)
-JSValue JSDOMWindow::messageChannel(ExecState* exec) const
-{
- return getDOMConstructor<JSMessageChannelConstructor>(exec, this);
-}
-#endif
-
-#if ENABLE(WORKERS)
-JSValue JSDOMWindow::worker(ExecState* exec) const
-{
- return getDOMConstructor<JSWorkerConstructor>(exec, this);
-}
-#endif
-
#if ENABLE(SHARED_WORKERS)
JSValue JSDOMWindow::sharedWorker(ExecState* exec) const
{
Modified: trunk/Source/WebCore/page/DOMWindow.idl (103223 => 103224)
--- trunk/Source/WebCore/page/DOMWindow.idl 2011-12-19 08:28:06 UTC (rev 103223)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2011-12-19 08:48:51 UTC (rev 103224)
@@ -512,16 +512,16 @@
attribute DOMStringMapConstructor DOMStringMap;
- attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator
- attribute [JSCCustomGetter] Int8ArrayConstructor Int8Array; // Usable with new operator
- attribute [JSCCustomGetter] Uint8ArrayConstructor Uint8Array; // Usable with new operator
- attribute [JSCCustomGetter] Int16ArrayConstructor Int16Array; // Usable with new operator
- attribute [JSCCustomGetter] Uint16ArrayConstructor Uint16Array; // Usable with new operator
- attribute [JSCCustomGetter] Int32ArrayConstructor Int32Array; // Usable with new operator
- attribute [JSCCustomGetter] Uint32ArrayConstructor Uint32Array; // Usable with new operator
- attribute [JSCCustomGetter] Float32ArrayConstructor Float32Array; // Usable with new operator
- attribute [JSCCustomGetter] Float64ArrayConstructor Float64Array; // Usable with new operator
- attribute [JSCCustomGetter] DataViewConstructor DataView; // Usable with new operator
+ attribute ArrayBufferConstructor ArrayBuffer; // Usable with new operator
+ attribute Int8ArrayConstructor Int8Array; // Usable with new operator
+ attribute Uint8ArrayConstructor Uint8Array; // Usable with new operator
+ attribute Int16ArrayConstructor Int16Array; // Usable with new operator
+ attribute Uint16ArrayConstructor Uint16Array; // Usable with new operator
+ attribute Int32ArrayConstructor Int32Array; // Usable with new operator
+ attribute Uint32ArrayConstructor Uint32Array; // Usable with new operator
+ attribute Float32ArrayConstructor Float32Array; // Usable with new operator
+ attribute Float64ArrayConstructor Float64Array; // Usable with new operator
+ attribute DataViewConstructor DataView; // Usable with new operator
attribute [Supplemented, JSCCustomGetter, Conditional=WEB_AUDIO, EnabledAtRuntime] AudioContextConstructor webkitAudioContext; // Usable with new operator
attribute [Supplemented, Conditional=WEB_AUDIO] AudioPannerNodeConstructor webkitAudioPannerNode; // Needed for panning model constants
@@ -564,9 +564,9 @@
attribute WebKitCSSKeyframeRuleConstructor WebKitCSSKeyframeRule;
attribute WebKitCSSKeyframesRuleConstructor WebKitCSSKeyframesRule;
- attribute [JSCCustomGetter] WebKitCSSMatrixConstructor WebKitCSSMatrix; // Usable with the new operator
+ attribute WebKitCSSMatrixConstructor WebKitCSSMatrix; // Usable with the new operator
- attribute [JSCCustomGetter] WebKitPointConstructor WebKitPoint; // Usable with new the operator
+ attribute WebKitPointConstructor WebKitPoint; // Usable with new the operator
attribute ClipboardConstructor Clipboard;
@@ -578,7 +578,7 @@
attribute RangeConstructor Range;
attribute RangeExceptionConstructor RangeException;
- attribute [JSCCustomGetter] EventSourceConstructor EventSource; // Usable with new the operator
+ attribute EventSourceConstructor EventSource; // Usable with new the operator
// Mozilla has a separate XMLDocument object for XML documents.
// We just use Document for this.
@@ -587,19 +587,19 @@
attribute DOMParserConstructor DOMParser;
attribute XMLSerializerConstructor XMLSerializer;
- attribute [JSCCustomGetter] XMLHttpRequestConstructor XMLHttpRequest; // Usable with the new operator
+ attribute XMLHttpRequestConstructor XMLHttpRequest; // Usable with the new operator
attribute XMLHttpRequestUploadConstructor XMLHttpRequestUpload;
attribute XMLHttpRequestExceptionConstructor XMLHttpRequestException;
- attribute [JSCCustomGetter,Conditional=XSLT] XSLTProcessorConstructor XSLTProcessor; // Usable with the new operator
+ attribute [Conditional=XSLT] XSLTProcessorConstructor XSLTProcessor; // Usable with the new operator
#if defined(ENABLE_CHANNEL_MESSAGING) && ENABLE_CHANNEL_MESSAGING
attribute MessagePortConstructor MessagePort;
- attribute [JSCCustomGetter] MessageChannelConstructor MessageChannel; // Usable with the new operator
+ attribute MessageChannelConstructor MessageChannel; // Usable with the new operator
#endif
#if defined(ENABLE_WORKERS) && ENABLE_WORKERS
- attribute [JSCCustomGetter] WorkerConstructor Worker; // Usable with the new operator
+ attribute WorkerConstructor Worker; // Usable with the new operator
#endif
#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
