Title: [103210] trunk/Source/WebCore
- Revision
- 103210
- Author
- [email protected]
- Date
- 2011-12-18 19:13:08 -0800 (Sun, 18 Dec 2011)
Log Message
Unreviewed, rolling out r103205.
http://trac.webkit.org/changeset/103205
https://bugs.webkit.org/show_bug.cgi?id=74833
There are valid characters above 0x80 when the string is
8bits (Requested by benjaminp on #webkit).
Patch by Sheriff Bot <[email protected]> on 2011-12-18
* dom/Document.cpp:
(WebCore::isValidNameASCII):
(WebCore::Document::isValidName):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (103209 => 103210)
--- trunk/Source/WebCore/ChangeLog 2011-12-19 03:07:55 UTC (rev 103209)
+++ trunk/Source/WebCore/ChangeLog 2011-12-19 03:13:08 UTC (rev 103210)
@@ -1,3 +1,16 @@
+2011-12-18 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r103205.
+ http://trac.webkit.org/changeset/103205
+ https://bugs.webkit.org/show_bug.cgi?id=74833
+
+ There are valid characters above 0x80 when the string is
+ 8bits (Requested by benjaminp on #webkit).
+
+ * dom/Document.cpp:
+ (WebCore::isValidNameASCII):
+ (WebCore::Document::isValidName):
+
2011-12-18 Luke Macpherson <[email protected]>
Separate box alignment and box pack values into separate enums.
Modified: trunk/Source/WebCore/dom/Document.cpp (103209 => 103210)
--- trunk/Source/WebCore/dom/Document.cpp 2011-12-19 03:07:55 UTC (rev 103209)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-12-19 03:13:08 UTC (rev 103210)
@@ -3775,10 +3775,9 @@
return true;
}
-template<typename CharType>
-static inline bool isValidNameASCII(const CharType* characters, unsigned length)
+static inline bool isValidNameASCII(const UChar* characters, unsigned length)
{
- CharType c = characters[0];
+ UChar c = characters[0];
if (!(isASCIIAlpha(c) || c == ':' || c == '_'))
return false;
@@ -3797,9 +3796,7 @@
if (!length)
return false;
- if (name.is8Bit())
- return isValidNameASCII(name.characters8(), length);
- const UChar* characters = name.characters16();
+ const UChar* characters = name.characters();
return isValidNameASCII(characters, length) || isValidNameNonASCII(characters, length);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
