Title: [103151] trunk/Source/WebCore
Revision
103151
Author
[email protected]
Date
2011-12-17 10:51:45 -0800 (Sat, 17 Dec 2011)

Log Message

Radical sign drawn incorrectly due to refactoring typo
https://bugs.webkit.org/show_bug.cgi?id=74780

Patch by David Barton <[email protected]> on 2011-12-17
Reviewed by Dan Bernstein.

LayoutTests/mathml/presentation/roots.xhtml shows the bug, but apparently its .png
checksum is ok so run-webkit-tests can't detect the problem.

* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
In revision 88250, one paintOffset should have been adjustedPaintOffset.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (103150 => 103151)


--- trunk/Source/WebCore/ChangeLog	2011-12-17 18:35:09 UTC (rev 103150)
+++ trunk/Source/WebCore/ChangeLog	2011-12-17 18:51:45 UTC (rev 103151)
@@ -1,3 +1,17 @@
+2011-12-17  David Barton  <[email protected]>
+
+        Radical sign drawn incorrectly due to refactoring typo
+        https://bugs.webkit.org/show_bug.cgi?id=74780
+
+        Reviewed by Dan Bernstein.
+
+        LayoutTests/mathml/presentation/roots.xhtml shows the bug, but apparently its .png
+        checksum is ok so run-webkit-tests can't detect the problem.
+
+        * rendering/mathml/RenderMathMLRoot.cpp:
+        (WebCore::RenderMathMLRoot::paint):
+        In revision 88250, one paintOffset should have been adjustedPaintOffset.
+
 2011-12-17  Adrienne Walker  <[email protected]>
 
         [chromium] Reverting r103011, r103135 due to Aura test failures

Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp (103150 => 103151)


--- trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp	2011-12-17 18:35:09 UTC (rev 103150)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp	2011-12-17 18:51:45 UTC (rev 103151)
@@ -142,7 +142,7 @@
     LayoutUnit start = adjustedPaintOffset.x() + indexWidth + gRadicalLeftMargin + style()->paddingLeft().value() - rootPad;
     adjustedPaintOffset.setY(adjustedPaintOffset.y() + style()->paddingTop().value() - rootPad);
     
-    FloatPoint topStart(start - topStartShift, paintOffset.y());
+    FloatPoint topStart(start - topStartShift, adjustedPaintOffset.y());
     FloatPoint bottomLeft(start - gRadicalBottomPointXPos * frontWidth , adjustedPaintOffset.y() + maxHeight + gRadicalBasePad);
     FloatPoint topLeft(start - gRadicalTopLeftPointXPos * frontWidth , adjustedPaintOffset.y() + gRadicalTopLeftPointYPos * maxHeight);
     FloatPoint leftEnd(start - frontWidth , topLeft.y() + gRadicalLeftEndYShift * style()->fontSize());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to