Diff
Modified: trunk/Source/WebCore/ChangeLog (103008 => 103009)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 02:15:22 UTC (rev 103009)
@@ -1,3 +1,14 @@
+2011-12-15 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r102652 and r102717.
+ http://trac.webkit.org/changeset/102652
+ http://trac.webkit.org/changeset/102717
+ https://bugs.webkit.org/show_bug.cgi?id=74674
+
+ Broke too many webs. (Requested by kling on #webkit).
+
+ * WebCore.exp.in:
+
2011-12-15 Anders Carlsson <[email protected]>
Lazily create the scrolling coordinator and add a setting for enabling it
Modified: trunk/Source/WebCore/WebCore.exp.in (103008 => 103009)
--- trunk/Source/WebCore/WebCore.exp.in 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-12-16 02:15:22 UTC (rev 103009)
@@ -140,7 +140,6 @@
__ZN7WebCore10ClientRectC1Ev
__ZN7WebCore10CredentialC1ERKN3WTF6StringES4_NS_21CredentialPersistenceE
__ZN7WebCore10CredentialC1Ev
-__ZN7WebCore10FloatPointC1ERK8_NSPoint
__ZN7WebCore10FloatPointC1ERKNS_8IntPointE
__ZN7WebCore10JSDocument6s_infoE
__ZN7WebCore10MouseEvent6createERKN3WTF12AtomicStringENS1_10PassRefPtrINS_9DOMWindowEEERKNS_18PlatformMouseEventEiNS5_INS_4NodeEEE
Modified: trunk/Source/WebKit2/ChangeLog (103008 => 103009)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 02:15:22 UTC (rev 103009)
@@ -1,3 +1,32 @@
+2011-12-15 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r102652 and r102717.
+ http://trac.webkit.org/changeset/102652
+ http://trac.webkit.org/changeset/102717
+ https://bugs.webkit.org/show_bug.cgi?id=74674
+
+ Broke too many webs. (Requested by kling on #webkit).
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView _updateWindowAndViewFrames]):
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/mac/WebPageProxyMac.mm:
+ (WebKit::WebPageProxy::windowAndViewFramesChanged):
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::windowAndViewFramesChanged):
+ * WebProcess/Plugins/PluginView.h:
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::windowRect):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::windowAndViewFramesChanged):
+ * WebProcess/WebPage/WebPage.h:
+ (WebKit::WebPage::windowFrameInScreenCoordinates):
+ (WebKit::WebPage::viewFrameInWindowCoordinates):
+ (WebKit::WebPage::accessibilityPosition):
+ * WebProcess/WebPage/WebPage.messages.in:
+ * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
+ (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
+
2011-12-15 Gustavo Noronha Silva <[email protected]>
[GTK] New API test for WindowProperties fails
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (103008 => 103009)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-12-16 02:15:22 UTC (rev 103009)
@@ -337,7 +337,7 @@
NSRect viewFrameInWindowCoordinates = [self convertRect:[self frame] toView:nil];
NSPoint accessibilityPosition = [[self accessibilityAttributeValue:NSAccessibilityPositionAttribute] pointValue];
- _data->_page->windowAndViewFramesChanged(windowFrameInScreenCoordinates, viewFrameInWindowCoordinates, accessibilityPosition);
+ _data->_page->windowAndViewFramesChanged(enclosingIntRect(windowFrameInScreenCoordinates), enclosingIntRect(viewFrameInWindowCoordinates), IntPoint(accessibilityPosition));
}
- (void)renewGState
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (103008 => 103009)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2011-12-16 02:15:22 UTC (rev 103009)
@@ -306,7 +306,7 @@
#if PLATFORM(MAC)
void updateWindowIsVisible(bool windowIsVisible);
- void windowAndViewFramesChanged(const WebCore::FloatRect& windowFrameInScreenCoordinates, const WebCore::FloatRect& viewFrameInWindowCoordinates, const WebCore::FloatPoint& accessibilityViewCoordinates);
+ void windowAndViewFramesChanged(const WebCore::IntRect& windowFrameInScreenCoordinates, const WebCore::IntRect& viewFrameInWindowCoordinates, const WebCore::IntPoint& accessibilityViewCoordinates);
void setComposition(const String& text, Vector<WebCore::CompositionUnderline> underlines, uint64_t selectionStart, uint64_t selectionEnd, uint64_t replacementRangeStart, uint64_t replacementRangeEnd);
void confirmComposition();
Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (103008 => 103009)
--- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2011-12-16 02:15:22 UTC (rev 103009)
@@ -151,7 +151,7 @@
process()->send(Messages::WebPage::SetWindowIsVisible(windowIsVisible), m_pageID);
}
-void WebPageProxy::windowAndViewFramesChanged(const FloatRect& windowFrameInScreenCoordinates, const FloatRect& viewFrameInWindowCoordinates, const FloatPoint& accessibilityViewCoordinates)
+void WebPageProxy::windowAndViewFramesChanged(const IntRect& windowFrameInScreenCoordinates, const IntRect& viewFrameInWindowCoordinates, const IntPoint& accessibilityViewCoordinates)
{
if (!isValid())
return;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-12-16 02:15:22 UTC (rev 103009)
@@ -414,12 +414,12 @@
m_plugin->contentsScaleFactorChanged(scaleFactor);
}
-void PluginView::windowAndViewFramesChanged(const FloatRect& windowFrameInScreenCoordinates, const FloatRect& viewFrameInWindowCoordinates)
+void PluginView::windowAndViewFramesChanged(const IntRect& windowFrameInScreenCoordinates, const IntRect& viewFrameInWindowCoordinates)
{
if (!m_isInitialized || !m_plugin)
return;
- m_plugin->windowAndViewFramesChanged(enclosingIntRect(windowFrameInScreenCoordinates), enclosingIntRect(viewFrameInWindowCoordinates));
+ m_plugin->windowAndViewFramesChanged(windowFrameInScreenCoordinates, viewFrameInWindowCoordinates);
}
bool PluginView::sendComplexTextInput(uint64_t pluginComplexTextInputIdentifier, const String& textInput)
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2011-12-16 02:15:22 UTC (rev 103009)
@@ -64,7 +64,7 @@
void setWindowIsVisible(bool);
void setWindowIsFocused(bool);
void setDeviceScaleFactor(float);
- void windowAndViewFramesChanged(const WebCore::FloatRect& windowFrameInScreenCoordinates, const WebCore::FloatRect& viewFrameInWindowCoordinates);
+ void windowAndViewFramesChanged(const WebCore::IntRect& windowFrameInScreenCoordinates, const WebCore::IntRect& viewFrameInWindowCoordinates);
bool sendComplexTextInput(uint64_t pluginComplexTextInputIdentifier, const String& textInput);
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-12-16 02:15:22 UTC (rev 103009)
@@ -105,12 +105,6 @@
FloatRect WebChromeClient::windowRect()
{
-#if PLATFORM(MAC)
- FloatRect cachedWindowFrame(m_page->windowFrameInScreenCoordinates());
- if (!cachedWindowFrame.isEmpty())
- return cachedWindowFrame;
-#endif
-
FloatRect newWindowFrame;
if (!WebProcess::shared().connection()->sendSync(Messages::WebPageProxy::GetWindowFrame(), Messages::WebPageProxy::GetWindowFrame::Reply(newWindowFrame), m_page->pageID()))
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-12-16 02:15:22 UTC (rev 103009)
@@ -2313,7 +2313,7 @@
(*it)->setWindowIsVisible(windowIsVisible);
}
-void WebPage::windowAndViewFramesChanged(const WebCore::FloatRect& windowFrameInScreenCoordinates, const WebCore::FloatRect& viewFrameInWindowCoordinates, const WebCore::FloatPoint& accessibilityViewCoordinates)
+void WebPage::windowAndViewFramesChanged(const WebCore::IntRect& windowFrameInScreenCoordinates, const WebCore::IntRect& viewFrameInWindowCoordinates, const WebCore::IntPoint& accessibilityViewCoordinates)
{
m_windowFrameInScreenCoordinates = windowFrameInScreenCoordinates;
m_viewFrameInWindowCoordinates = viewFrameInWindowCoordinates;
@@ -2321,7 +2321,7 @@
// Tell all our plug-in views that the window and view frames have changed.
for (HashSet<PluginView*>::const_iterator it = m_pluginViews.begin(), end = m_pluginViews.end(); it != end; ++it)
- (*it)->windowAndViewFramesChanged(enclosingIntRect(windowFrameInScreenCoordinates), enclosingIntRect(viewFrameInWindowCoordinates));
+ (*it)->windowAndViewFramesChanged(windowFrameInScreenCoordinates, viewFrameInWindowCoordinates);
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2011-12-16 02:15:22 UTC (rev 103009)
@@ -289,8 +289,8 @@
void removePluginView(PluginView*);
bool windowIsVisible() const { return m_windowIsVisible; }
- const WebCore::FloatRect& windowFrameInScreenCoordinates() const { return m_windowFrameInScreenCoordinates; }
- const WebCore::FloatRect& viewFrameInWindowCoordinates() const { return m_viewFrameInWindowCoordinates; }
+ const WebCore::IntRect& windowFrameInScreenCoordinates() const { return m_windowFrameInScreenCoordinates; }
+ const WebCore::IntRect& viewFrameInWindowCoordinates() const { return m_viewFrameInWindowCoordinates; }
#elif PLATFORM(WIN)
HWND nativeWindow() const { return m_nativeWindow; }
#endif
@@ -356,8 +356,8 @@
#if PLATFORM(MAC)
void registerUIProcessAccessibilityTokens(const CoreIPC::DataReference& elemenToken, const CoreIPC::DataReference& windowToken);
WKAccessibilityWebPageObject* accessibilityRemoteObject();
- const WebCore::FloatPoint& accessibilityPosition() const { return m_accessibilityPosition; }
-
+ WebCore::IntPoint accessibilityPosition() const { return m_accessibilityPosition; }
+
void sendComplexTextInputToPlugin(uint64_t pluginComplexTextInputIdentifier, const String& textInput);
void setComposition(const String& text, Vector<WebCore::CompositionUnderline> underlines, uint64_t selectionStart, uint64_t selectionEnd, uint64_t replacementRangeStart, uint64_t replacementRangeEnd, EditorState& newState);
@@ -561,7 +561,7 @@
void performDictionaryLookupForRange(DictionaryPopupInfo::Type, WebCore::Frame*, WebCore::Range*, NSDictionary *options);
void setWindowIsVisible(bool windowIsVisible);
- void windowAndViewFramesChanged(const WebCore::FloatRect& windowFrameInScreenCoordinates, const WebCore::FloatRect& viewFrameInWindowCoordinates, const WebCore::FloatPoint& accessibilityViewCoordinates);
+ void windowAndViewFramesChanged(const WebCore::IntRect& windowFrameInScreenCoordinates, const WebCore::IntRect& viewFrameInWindowCoordinates, const WebCore::IntPoint& accessibilityViewCoordinates);
#endif
void unapplyEditCommand(uint64_t commandID);
@@ -638,14 +638,14 @@
bool m_isSmartInsertDeleteEnabled;
// The frame of the containing window in screen coordinates.
- WebCore::FloatRect m_windowFrameInScreenCoordinates;
+ WebCore::IntRect m_windowFrameInScreenCoordinates;
// The frame of the view in window coordinates.
- WebCore::FloatRect m_viewFrameInWindowCoordinates;
+ WebCore::IntRect m_viewFrameInWindowCoordinates;
// The accessibility position of the view.
- WebCore::FloatPoint m_accessibilityPosition;
-
+ WebCore::IntPoint m_accessibilityPosition;
+
// All plug-in views on this web page.
HashSet<PluginView*> m_pluginViews;
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in 2011-12-16 02:15:22 UTC (rev 103009)
@@ -200,7 +200,7 @@
SendComplexTextInputToPlugin(uint64_t pluginComplexTextInputIdentifier, String textInput)
SetWindowIsVisible(bool windowIsVisible)
- WindowAndViewFramesChanged(WebCore::FloatRect windowFrameInScreenCoordinates, WebCore::FloatRect viewFrameInWindowCoordinates, WebCore::FloatPoint accessibilityViewCoordinates)
+ WindowAndViewFramesChanged(WebCore::IntRect windowFrameInScreenCoordinates, WebCore::IntRect viewFrameInWindowCoordinates, WebCore::IntPoint accessibilityViewCoordinates)
RegisterUIProcessAccessibilityTokens(CoreIPC::DataReference elemenToken, CoreIPC::DataReference windowToken)
WriteSelectionToPasteboard(WTF::String pasteboardName, WTF::Vector<WTF::String> pasteboardTypes) -> (bool result)
ReadSelectionFromPasteboard(WTF::String pasteboardName) -> (bool result)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm (103008 => 103009)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm 2011-12-16 02:00:43 UTC (rev 103008)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm 2011-12-16 02:15:22 UTC (rev 103009)
@@ -142,7 +142,7 @@
return nil;
if ([attribute isEqualToString:NSAccessibilityPositionAttribute]) {
- const WebCore::FloatPoint& point = m_page->accessibilityPosition();
+ WebCore::IntPoint point = m_page->accessibilityPosition();
return [NSValue valueWithPoint:NSMakePoint(point.x(), point.y())];
}
if ([attribute isEqualToString:NSAccessibilitySizeAttribute]) {
