Title: [249044] trunk/Source/WebCore
Revision
249044
Author
simon.fra...@apple.com
Date
2019-08-23 08:14:46 -0700 (Fri, 23 Aug 2019)

Log Message

Don't call clipCrossesPaintingBoundary() when not necessary
https://bugs.webkit.org/show_bug.cgi?id=201064

Reviewed by Zalan Bujtas.

clipCrossesPaintingBoundary() does some RenderLayer ancestor walks, so avoid
calling it when we already know that the clip rects are TemporaryClipRects.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (249043 => 249044)


--- trunk/Source/WebCore/ChangeLog	2019-08-23 10:53:00 UTC (rev 249043)
+++ trunk/Source/WebCore/ChangeLog	2019-08-23 15:14:46 UTC (rev 249044)
@@ -1,3 +1,16 @@
+2019-08-23  Simon Fraser  <simon.fra...@apple.com>
+
+        Don't call clipCrossesPaintingBoundary() when not necessary
+        https://bugs.webkit.org/show_bug.cgi?id=201064
+
+        Reviewed by Zalan Bujtas.
+
+        clipCrossesPaintingBoundary() does some RenderLayer ancestor walks, so avoid
+        calling it when we already know that the clip rects are TemporaryClipRects.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::calculateClipRects const):
+
 2019-08-23  Philippe Normand  <pnorm...@igalia.com>
 
         [GStreamer] Hole-punch build is broken

Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (249043 => 249044)


--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-08-23 10:53:00 UTC (rev 249043)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-08-23 15:14:46 UTC (rev 249044)
@@ -5590,7 +5590,7 @@
             ClipRectsContext parentContext(clipRectsContext);
             parentContext.overlayScrollbarSizeRelevancy = IgnoreOverlayScrollbarSize; // FIXME: why?
             
-            if (clipCrossesPaintingBoundary())
+            if (parentContext.clipRectsType != TemporaryClipRects && clipCrossesPaintingBoundary())
                 parentContext.clipRectsType = TemporaryClipRects;
 
             parentLayer->calculateClipRects(parentContext, clipRects);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to