Title: [102677] trunk/Tools
- Revision
- 102677
- Author
- commit-qu...@webkit.org
- Date
- 2011-12-13 05:41:30 -0800 (Tue, 13 Dec 2011)
Log Message
[NRWT] It crashes intermittently when there are WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=73451
Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
Patch by János Badics <dic...@gmail.com> on 2011-12-13
Reviewed by Kenneth Rohde Christiansen.
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._check_for_crash):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (102676 => 102677)
--- trunk/Tools/ChangeLog 2011-12-13 13:39:49 UTC (rev 102676)
+++ trunk/Tools/ChangeLog 2011-12-13 13:41:30 UTC (rev 102677)
@@ -1,3 +1,15 @@
+2011-12-13 János Badics <dic...@gmail.com>
+
+ [NRWT] It crashes intermittently when there are WebProcess crashes
+ https://bugs.webkit.org/show_bug.cgi?id=73451
+
+ Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * Scripts/webkitpy/layout_tests/port/server_process.py:
+ (ServerProcess._check_for_crash):
+
2011-12-13 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed. Fix GTK+ API docs build.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py (102676 => 102677)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2011-12-13 13:39:49 UTC (rev 102676)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2011-12-13 13:41:30 UTC (rev 102677)
@@ -179,7 +179,7 @@
return self._read(deadline, retrieve_bytes_from_stdout_buffer)
def _check_for_crash(self, wait_for_crash_reporter=True):
- if self._proc.poll() != None:
+ if self.poll() != None:
self.set_crashed(True, wait_for_crash_reporter)
self.handle_interrupt()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
