Title: [102336] trunk/Source/WebKit2
- Revision
- 102336
- Author
- [email protected]
- Date
- 2011-12-08 07:29:13 -0800 (Thu, 08 Dec 2011)
Log Message
[Qt] Fix the memory leak of AC layer update message contents on the UI process.
https://bugs.webkit.org/show_bug.cgi?id=74012
Reviewed by Noam Rosenthal.
Since the messages didn't have a virtual destructor, the destructor
of child class members wouldn't be called and would cause the all tile
update buffers, contained in a QImage, to be leaked as well.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (102335 => 102336)
--- trunk/Source/WebKit2/ChangeLog 2011-12-08 14:50:55 UTC (rev 102335)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-08 15:29:13 UTC (rev 102336)
@@ -1,3 +1,17 @@
+2011-12-07 Jocelyn Turcotte <[email protected]>
+
+ [Qt] Fix the memory leak of AC layer update message contents on the UI process.
+ https://bugs.webkit.org/show_bug.cgi?id=74012
+
+ Reviewed by Noam Rosenthal.
+
+ Since the messages didn't have a virtual destructor, the destructor
+ of child class members wouldn't be called and would cause the all tile
+ update buffers, contained in a QImage, to be leaked as well.
+
+ * UIProcess/qt/LayerTreeHostProxyQt.cpp:
+ (WebKit::LayerTreeMessageToRenderer::~LayerTreeMessageToRenderer):
+
2011-12-08 Kenneth Rohde Christiansen <[email protected]>
Upsteam the Qt changes to the EditorState
Modified: trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp (102335 => 102336)
--- trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2011-12-08 14:50:55 UTC (rev 102335)
+++ trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp 2011-12-08 15:29:13 UTC (rev 102336)
@@ -53,6 +53,7 @@
FlushLayerChanges,
SetRootLayer
};
+ virtual ~LayerTreeMessageToRenderer() { }
virtual Type type() const = 0;
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
