Title: [242811] trunk/Source/WebInspectorUI
- Revision
- 242811
- Author
- [email protected]
- Date
- 2019-03-12 12:03:01 -0700 (Tue, 12 Mar 2019)
Log Message
Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed
https://bugs.webkit.org/show_bug.cgi?id=195522
Reviewed by Matt Baker.
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype._updateBreakpointStatus):
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.get hasBreakpoint): Added.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242810 => 242811)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 19:02:22 UTC (rev 242810)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 19:03:01 UTC (rev 242811)
@@ -1,5 +1,17 @@
2019-03-12 Devin Rousso <[email protected]>
+ Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed
+ https://bugs.webkit.org/show_bug.cgi?id=195522
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WI.DOMTreeContentView.prototype._updateBreakpointStatus):
+ * UserInterface/Views/DOMTreeElement.js:
+ (WI.DOMTreeElement.prototype.get hasBreakpoint): Added.
+
+2019-03-12 Devin Rousso <[email protected]>
+
Web Inspector: Canvas: export recording as HTML
https://bugs.webkit.org/show_bug.cgi?id=195311
<rdar://problem/48588673>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (242810 => 242811)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2019-03-12 19:02:22 UTC (rev 242810)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2019-03-12 19:03:01 UTC (rev 242811)
@@ -771,15 +771,15 @@
}
let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);
- if (!breakpoints.length) {
+ if (breakpoints.length) {
+ if (breakpoints.some((item) => item.disabled))
+ treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint;
+ else
+ treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint;
+ } else
treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None;
- return;
- }
- this.breakpointGutterEnabled = true;
-
- let disabled = breakpoints.some((item) => item.disabled);
- treeElement.breakpointStatus = disabled ? WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint : WI.DOMTreeElement.BreakpointStatus.Breakpoint;
+ this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint);
}
_restoreBreakpointsAfterUpdate()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (242810 => 242811)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-03-12 19:02:22 UTC (rev 242810)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2019-03-12 19:03:01 UTC (rev 242811)
@@ -72,6 +72,11 @@
// Public
+ get hasBreakpoint()
+ {
+ return this._breakpointStatus !== WI.DOMTreeElement.BreakpointStatus.None || this._subtreeBreakpointCount > 0;
+ }
+
get breakpointStatus()
{
return this._breakpointStatus;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
