Title: [239657] trunk/Tools
Revision
239657
Author
aakash_j...@apple.com
Date
2019-01-05 04:01:10 -0800 (Sat, 05 Jan 2019)

Log Message

Unreviewed follow-up fix to r239650
https://bugs.webkit.org/show_bug.cgi?id=193140
<rdar://problem/47063037>

Typecast patch_id to string.

* BuildSlaveSupport/ews-build/steps.py:
(ValidatePatch._is_patch_obsolete):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (239656 => 239657)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-01-05 11:30:16 UTC (rev 239656)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-01-05 12:01:10 UTC (rev 239657)
@@ -287,7 +287,7 @@
             self._addToLog('stdio', 'Unable to fetch patch {}.\n'.format(patch_id))
             return -1
 
-        if patch_json.get('id') != self.getProperty('patch_id', ''):
+        if str(patch_json.get('id')) != self.getProperty('patch_id', ''):
             self._addToLog('stdio', 'Fetched patch id {} does not match with requested patch id {}. Unable to validate.\n'.format(patch_json.get('id'), self.getProperty('patch_id', '')))
             return -1
 

Modified: trunk/Tools/ChangeLog (239656 => 239657)


--- trunk/Tools/ChangeLog	2019-01-05 11:30:16 UTC (rev 239656)
+++ trunk/Tools/ChangeLog	2019-01-05 12:01:10 UTC (rev 239657)
@@ -1,3 +1,14 @@
+2019-01-05  Aakash Jain  <aakash_j...@apple.com>
+
+        Unreviewed follow-up fix to r239650
+        https://bugs.webkit.org/show_bug.cgi?id=193140
+        <rdar://problem/47063037>
+
+        Typecast patch_id to string.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ValidatePatch._is_patch_obsolete):
+
 2019-01-04  Daniel Bates  <daba...@apple.com>
 
         [lldb-webkit]: Add support for pretty-printing raw bitmask types
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to