Title: [239613] trunk
- Revision
- 239613
- Author
- cfleiz...@apple.com
- Date
- 2019-01-04 09:18:17 -0800 (Fri, 04 Jan 2019)
Log Message
AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
https://bugs.webkit.org/show_bug.cgi?id=193041
<rdar://problem/46954090>
Reviewed by Zalan Bujtas.
Source/WebCore:
* en.lproj/Localizable.strings:
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::AXHorizontalRuleDescriptionText):
LayoutTests:
* accessibility/mac/hr-element-expected.txt:
* platform/mac/accessibility/roles-exposed-expected.txt:
* platform/mac-wk2/accessibility/roles-exposed-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239612 => 239613)
--- trunk/LayoutTests/ChangeLog 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/LayoutTests/ChangeLog 2019-01-04 17:18:17 UTC (rev 239613)
@@ -1,3 +1,15 @@
+2019-01-04 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+ https://bugs.webkit.org/show_bug.cgi?id=193041
+ <rdar://problem/46954090>
+
+ Reviewed by Zalan Bujtas.
+
+ * accessibility/mac/hr-element-expected.txt:
+ * platform/mac/accessibility/roles-exposed-expected.txt:
+ * platform/mac-wk2/accessibility/roles-exposed-expected.txt:
+
2019-01-04 Frederic Wang <fw...@igalia.com>
Flaky Test: http/wpt/css/css-animations/start-animation-001.html
Modified: trunk/LayoutTests/accessibility/mac/hr-element-expected.txt (239612 => 239613)
--- trunk/LayoutTests/accessibility/mac/hr-element-expected.txt 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/LayoutTests/accessibility/mac/hr-element-expected.txt 2019-01-04 17:18:17 UTC (rev 239613)
@@ -5,7 +5,7 @@
hr1 role: AXRole: AXSplitter
hr1 subrole: AXSubrole: AXContentSeparator
-hr1 roleDescription: AXRoleDescription: rule
+hr1 roleDescription: AXRoleDescription: separator
hr1 description: AXDescription:
hr1 is value settable: false
hr1 orientation: AXOrientation: AXHorizontalOrientation
@@ -13,7 +13,7 @@
hr2 role: AXRole: AXSplitter
hr2 subrole: AXSubrole: AXContentSeparator
-hr2 roleDescription: AXRoleDescription: rule
+hr2 roleDescription: AXRoleDescription: separator
hr2 description: AXDescription:
hr2 is value settable: false
hr2 orientation: AXOrientation: AXHorizontalOrientation
@@ -21,7 +21,7 @@
hr3 role: AXRole: AXSplitter
hr3 subrole: AXSubrole: AXContentSeparator
-hr3 roleDescription: AXRoleDescription: rule
+hr3 roleDescription: AXRoleDescription: separator
hr3 description: AXDescription: RULER
hr3 is value settable: false
hr3 orientation: AXOrientation: AXHorizontalOrientation
@@ -29,7 +29,7 @@
hr4 role: AXRole: AXSplitter
hr4 subrole: AXSubrole: AXContentSeparator
-hr4 roleDescription: AXRoleDescription: rule
+hr4 roleDescription: AXRoleDescription: separator
hr4 description: AXDescription:
hr4 is value settable: false
hr4 orientation: AXOrientation: AXVerticalOrientation
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (239612 => 239613)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2019-01-04 17:18:17 UTC (rev 239613)
@@ -182,7 +182,7 @@
hr
AXRole: AXSplitter
AXSubrole: AXContentSeparator
- AXRoleDescription: rule
+ AXRoleDescription: separator
i
AXRole:
Modified: trunk/LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt (239612 => 239613)
--- trunk/LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt 2019-01-04 17:18:17 UTC (rev 239613)
@@ -182,7 +182,7 @@
hr
AXRole: AXSplitter
AXSubrole: AXContentSeparator
- AXRoleDescription: rule
+ AXRoleDescription: separator
i
AXRole:
Modified: trunk/Source/WebCore/ChangeLog (239612 => 239613)
--- trunk/Source/WebCore/ChangeLog 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/Source/WebCore/ChangeLog 2019-01-04 17:18:17 UTC (rev 239613)
@@ -1,3 +1,15 @@
+2019-01-04 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+ https://bugs.webkit.org/show_bug.cgi?id=193041
+ <rdar://problem/46954090>
+
+ Reviewed by Zalan Bujtas.
+
+ * en.lproj/Localizable.strings:
+ * platform/cocoa/LocalizedStringsCocoa.mm:
+ (WebCore::AXHorizontalRuleDescriptionText):
+
2019-01-04 Zalan Bujtas <za...@apple.com>
[LFC] ComputedHorizontalMargin should have optional members
Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (239612 => 239613)
--- trunk/Source/WebCore/en.lproj/Localizable.strings 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings 2019-01-04 17:18:17 UTC (rev 239613)
@@ -1250,7 +1250,7 @@
"return to realtime" = "return to realtime";
/* accessibility role description for a horizontal rule [<hr>] */
-"rule" = "rule";
+"separator" = "separator";
/* An ARIA accessibility group that contains a search feature of a website. */
"search" = "search";
Modified: trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm (239612 => 239613)
--- trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2019-01-04 17:04:09 UTC (rev 239612)
+++ trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm 2019-01-04 17:18:17 UTC (rev 239613)
@@ -230,7 +230,7 @@
String AXHorizontalRuleDescriptionText()
{
- return WEB_UI_STRING("rule", "accessibility role description for a horizontal rule [<hr>]");
+ return WEB_UI_STRING("separator", "accessibility role description for a horizontal rule [<hr>]");
}
String AXMarkText()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
