Title: [101920] trunk
- Revision
- 101920
- Author
- [email protected]
- Date
- 2011-12-03 02:26:48 -0800 (Sat, 03 Dec 2011)
Log Message
[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=66968
Reviewed by Martin Robinson.
Source/WebCore:
* GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,
it wasn't suited for GTK in the first place anyway.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.
Source/WebKit/gtk:
If the element being fullscreened is a video use the native
fullscreen controls.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):
LayoutTests:
* platform/gtk/Skipped: Skip
fullscreen/video-controls-override.html now failing because of bug 73583.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (101919 => 101920)
--- trunk/LayoutTests/ChangeLog 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/LayoutTests/ChangeLog 2011-12-03 10:26:48 UTC (rev 101920)
@@ -1,3 +1,13 @@
+2011-12-03 Philippe Normand <[email protected]>
+
+ [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
+ https://bugs.webkit.org/show_bug.cgi?id=66968
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/Skipped: Skip
+ fullscreen/video-controls-override.html now failing because of bug 73583.
+
2011-12-03 Csaba Osztrogonác <[email protected]>
[Qt] Unreviewed weekend gardening.
Modified: trunk/LayoutTests/platform/gtk/Skipped (101919 => 101920)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-12-03 10:26:48 UTC (rev 101920)
@@ -1588,3 +1588,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=73666
http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=73583
+fullscreen/video-controls-override.html
Modified: trunk/Source/WebCore/ChangeLog (101919 => 101920)
--- trunk/Source/WebCore/ChangeLog 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/Source/WebCore/ChangeLog 2011-12-03 10:26:48 UTC (rev 101920)
@@ -1,3 +1,16 @@
+2011-12-02 Philippe Normand <[email protected]>
+
+ [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
+ https://bugs.webkit.org/show_bug.cgi?id=66968
+
+ Reviewed by Martin Robinson.
+
+ * GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,
+ it wasn't suited for GTK in the first place anyway.
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
+ GTK CSS.
+
2011-12-03 Alejandro G. Castro <[email protected]>
[GTK] TextureMapperNode should not use Qt types and functions
Modified: trunk/Source/WebCore/GNUmakefile.am (101919 => 101920)
--- trunk/Source/WebCore/GNUmakefile.am 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/Source/WebCore/GNUmakefile.am 2011-12-03 10:26:48 UTC (rev 101920)
@@ -663,8 +663,7 @@
$(WebCore)/css/svg.css \
$(WebCore)/css/mediaControls.css \
$(WebCore)/css/mediaControlsGtk.css \
- $(WebCore)/css/fullscreen.css \
- $(WebCore)/css/fullscreenQuickTime.css
+ $(WebCore)/css/fullscreen.css
# new-style _javascript_ bindings
SCRIPTS_BINDINGS = \
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (101919 => 101920)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2011-12-03 10:26:48 UTC (rev 101920)
@@ -481,7 +481,7 @@
#if ENABLE(FULLSCREEN_API)
String RenderThemeGtk::extraFullScreenStyleSheet()
{
- return String(fullscreenQuickTimeUserAgentStyleSheet, sizeof(fullscreenQuickTimeUserAgentStyleSheet));
+ return String();
}
#endif
Modified: trunk/Source/WebKit/gtk/ChangeLog (101919 => 101920)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-12-03 10:26:48 UTC (rev 101920)
@@ -1,3 +1,17 @@
+2011-12-02 Philippe Normand <[email protected]>
+
+ [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
+ https://bugs.webkit.org/show_bug.cgi?id=66968
+
+ Reviewed by Martin Robinson.
+
+ If the element being fullscreened is a video use the native
+ fullscreen controls.
+
+ * WebCoreSupport/ChromeClientGtk.cpp:
+ (WebKit::ChromeClient::enterFullScreenForElement):
+ (WebKit::ChromeClient::exitFullScreenForElement):
+
2011-12-01 Philippe Normand <[email protected]>
[GTK] scrollbars interfering with fullscreen (in-window) video rendering
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (101919 => 101920)
--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2011-12-03 09:44:59 UTC (rev 101919)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2011-12-03 10:26:48 UTC (rev 101920)
@@ -890,6 +890,10 @@
{
element->document()->webkitWillEnterFullScreenForElement(element);
m_adjustmentWatcher.disableAllScrollbars();
+#if ENABLE(VIDEO)
+ if (element->tagName() == "VIDEO")
+ enterFullscreenForNode(static_cast<Node*>(element));
+#endif
element->document()->webkitDidEnterFullScreenForElement(element);
}
@@ -897,6 +901,10 @@
{
element->document()->webkitWillExitFullScreenForElement(element);
m_adjustmentWatcher.enableAllScrollbars();
+#if ENABLE(VIDEO)
+ if (element->tagName() == "VIDEO")
+ webViewExitFullscreen(m_webView);
+#endif
element->document()->webkitDidExitFullScreenForElement(element);
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
