Title: [101915] trunk
Revision
101915
Author
[email protected]
Date
2011-12-03 01:06:15 -0800 (Sat, 03 Dec 2011)

Log Message

Unreviewed, rolling out r101904.
http://trac.webkit.org/changeset/101904
https://bugs.webkit.org/show_bug.cgi?id=73739

It broke zillions of tests on all bot (Requested by
Ossy_weekend on #webkit).

Patch by Sheriff Bot <[email protected]> on 2011-12-03

Source/WebCore:

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):

LayoutTests:

* fast/dom/Window/window-postmessage-args-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (101914 => 101915)


--- trunk/LayoutTests/ChangeLog	2011-12-03 07:22:10 UTC (rev 101914)
+++ trunk/LayoutTests/ChangeLog	2011-12-03 09:06:15 UTC (rev 101915)
@@ -1,3 +1,14 @@
+2011-12-03  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r101904.
+        http://trac.webkit.org/changeset/101904
+        https://bugs.webkit.org/show_bug.cgi?id=73739
+
+        It broke zillions of tests on all bot (Requested by
+        Ossy_weekend on #webkit).
+
+        * fast/dom/Window/window-postmessage-args-expected.txt:
+
 2011-12-02  Tony Chang  <[email protected]>
 
         remove a stale comment in flexbox code

Modified: trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt (101914 => 101915)


--- trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt	2011-12-03 07:22:10 UTC (rev 101914)
+++ trunk/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt	2011-12-03 09:06:15 UTC (rev 101915)
@@ -6,35 +6,28 @@
 PASS: Posting message ('2', c): threw exception TypeError: Type error
 PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
 PASS: Posting message ('3', [object Object]): threw exception TypeError: Type error
-PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
-PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
+FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
+FAIL: Posting message ('4', [object DOMWindow]): threw exception TypeError: Type error
 PASS: Posting message ('5', null) did not throw an exception
 PASS: Posting message ('5', null) did not throw an exception
 PASS: Posting message ('6', undefined) did not throw an exception
 PASS: Posting message ('6', undefined) did not throw an exception
-PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
+FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('7', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
 PASS: Posting message ('2147483648', null) did not throw an exception
 PASS: Posting message ('2147483648', null) did not throw an exception
-PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
-PASS: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]) did not throw an exception
+FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
+FAIL: Posting message ('[object MessagePort],[object MessagePort]', [object MessagePort],[object MessagePort]): threw exception TypeError: Type error
 FAIL: Posting message ('[object ArrayBuffer]', [object ArrayBuffer]): threw exception TypeError: Type error
 FAIL: arrayBuffer not neutered; byteLength = 30
 FAIL: view was not neutered; length = 10
 PASS: Posting message ('done', undefined) did not throw an exception
-Received message '4' with 0 ports.
-Received message '4' with 0 ports.
 Received message '5' with 0 ports.
 Received message '5' with 0 ports.
 Received message '6' with 0 ports.
 Received message '6' with 0 ports.
-Received message '7' with 2 ports.
-Received message '7' with 2 ports.
 Received message '2147483648' with 0 ports.
 Received message '2147483648' with 0 ports.
-Received message '[object Object]' with 2 ports.
-Received message '[object MessagePort]' with 2 ports.
-Received message '[object MessagePort],[object MessagePort]' with 2 ports.
 Received message 'done' with 0 ports.
 

Modified: trunk/Source/WebCore/ChangeLog (101914 => 101915)


--- trunk/Source/WebCore/ChangeLog	2011-12-03 07:22:10 UTC (rev 101914)
+++ trunk/Source/WebCore/ChangeLog	2011-12-03 09:06:15 UTC (rev 101915)
@@ -1,3 +1,15 @@
+2011-12-03  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r101904.
+        http://trac.webkit.org/changeset/101904
+        https://bugs.webkit.org/show_bug.cgi?id=73739
+
+        It broke zillions of tests on all bot (Requested by
+        Ossy_weekend on #webkit).
+
+        * bindings/js/JSDOMWindowCustom.cpp:
+        (WebCore::handlePostMessage):
+
 2011-12-02  Kentaro Hara  <[email protected]>
 
         [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm

Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (101914 => 101915)


--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2011-12-03 07:22:10 UTC (rev 101914)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2011-12-03 09:06:15 UTC (rev 101915)
@@ -706,7 +706,7 @@
 {
     MessagePortArray messagePorts;
     if (exec->argumentCount() > 2)
-        fillMessagePortArray(exec, exec->argument(2), messagePorts);
+        fillMessagePortArray(exec, exec->argument(1), messagePorts);
     if (exec->hadException())
         return jsUndefined();
 
@@ -716,7 +716,7 @@
     if (exec->hadException())
         return jsUndefined();
 
-    String targetOrigin = valueToStringWithUndefinedOrNullCheck(exec, exec->argument(1));
+    String targetOrigin = valueToStringWithUndefinedOrNullCheck(exec, exec->argument((exec->argumentCount() == 2) ? 1 : 2));
     if (exec->hadException())
         return jsUndefined();
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to