Title: [101696] trunk/LayoutTests
- Revision
- 101696
- Author
- [email protected]
- Date
- 2011-12-01 12:02:31 -0800 (Thu, 01 Dec 2011)
Log Message
Cleaning up comments and unused portions of a webgl test, as per review comments.
https://bugs.webkit.org/show_bug.cgi?id=73033
Patch by Jeff Timanus <[email protected]> on 2011-12-01
Reviewed by Stephen White.
* fast/canvas/webgl/webgl-texture-binding-preserved.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (101695 => 101696)
--- trunk/LayoutTests/ChangeLog 2011-12-01 19:58:49 UTC (rev 101695)
+++ trunk/LayoutTests/ChangeLog 2011-12-01 20:02:31 UTC (rev 101696)
@@ -1,3 +1,12 @@
+2011-12-01 Jeff Timanus <[email protected]>
+
+ Cleaning up comments and unused portions of a webgl test, as per review comments.
+ https://bugs.webkit.org/show_bug.cgi?id=73033
+
+ Reviewed by Stephen White.
+
+ * fast/canvas/webgl/webgl-texture-binding-preserved.html:
+
2011-12-01 Ilya Tikhonovsky <[email protected]>
Web Inspector: chromium: move and adapt Inspector's performance tests for running with run-inspector-perf-tests.py.
Modified: trunk/LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html (101695 => 101696)
--- trunk/LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html 2011-12-01 19:58:49 UTC (rev 101695)
+++ trunk/LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html 2011-12-01 20:02:31 UTC (rev 101696)
@@ -19,17 +19,16 @@
var canvas;
var context;
-var requestAnimationFrame;
function draw() {
// Draw a blue quad to the screen. The compositor should have executed
- // before reaching this point. If the texture state was corruted, then
+ // before reaching this point. If the texture state was corrupted, then
// a red quad will be drawn. See crbug.com/105045.
wtu.drawQuad(context);
wtu.checkCanvasRect(context, 0, 0, 1, 1, [0, 0, 255, 255], "Should have rendered blue.", 1);
if (window.layoutTestController)
- layoutTestController.notifyDone();
+ layoutTestController.notifyDone();
}
window._onload_ = function()
@@ -39,7 +38,6 @@
}
canvas = document.getElementById("webgl-canvas");
- canvas.width = 50; canvas.height = 50;
context = create3DContext(canvas);
requestAnimationFrame = window.webkitRequestAnimationFrame
@@ -59,7 +57,9 @@
context.clear(context.COLOR_BUFFER_BIT | context.DEPTH_BUFFER_BIT);
// We need to ensure that the compositor has run before the drawing
- // takes place.
+ // takes place. requestAnimationFrame was tried for this purpose,
+ // but it did not produce the failing behaviour in crbug.com/105045.
+ // A timeout of 100 ms was found to consistently reproduce the problem.
setTimeout(draw, 100);
}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
