Title: [235761] trunk/Tools
- Revision
- 235761
- Author
- [email protected]
- Date
- 2018-09-06 15:25:59 -0700 (Thu, 06 Sep 2018)
Log Message
An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures
https://bugs.webkit.org/show_bug.cgi?id=189368
Reviewed by Alexey Proskuryakov.
Include FailureDocumentLeak in ALL_FAILURE_CLASSES (with a fairly redundant test),
which should fix EWS showing leaks in Bugzilla.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureDocumentLeak.__init__):
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_all_failure_classes):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235760 => 235761)
--- trunk/Tools/ChangeLog 2018-09-06 22:10:16 UTC (rev 235760)
+++ trunk/Tools/ChangeLog 2018-09-06 22:25:59 UTC (rev 235761)
@@ -1,3 +1,18 @@
+2018-09-06 Simon Fraser <[email protected]>
+
+ An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures
+ https://bugs.webkit.org/show_bug.cgi?id=189368
+
+ Reviewed by Alexey Proskuryakov.
+
+ Include FailureDocumentLeak in ALL_FAILURE_CLASSES (with a fairly redundant test),
+ which should fix EWS showing leaks in Bugzilla.
+
+ * Scripts/webkitpy/layout_tests/models/test_failures.py:
+ (FailureDocumentLeak.__init__):
+ * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
+ (TestFailuresTest.test_all_failure_classes):
+
2018-09-06 Commit Queue <[email protected]>
Unreviewed, rolling out r235755.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py (235760 => 235761)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2018-09-06 22:10:16 UTC (rev 235760)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2018-09-06 22:25:59 UTC (rev 235761)
@@ -171,7 +171,7 @@
class FailureDocumentLeak(FailureLeak):
- def __init__(self, leaked_document_urls):
+ def __init__(self, leaked_document_urls=None):
super(FailureDocumentLeak, self).__init__()
self.leaked_document_urls = leaked_document_urls
@@ -295,5 +295,5 @@
FailureMissingImage, FailureImageHashMismatch,
FailureImageHashIncorrect, FailureReftestMismatch,
FailureReftestMismatchDidNotOccur, FailureReftestNoImagesGenerated,
- FailureMissingAudio, FailureAudioMismatch,
+ FailureMissingAudio, FailureAudioMismatch, FailureDocumentLeak,
FailureEarlyExit)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py (235760 => 235761)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py 2018-09-06 22:10:16 UTC (rev 235760)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py 2018-09-06 22:25:59 UTC (rev 235761)
@@ -59,6 +59,26 @@
for c in ALL_FAILURE_CLASSES:
self.assert_loads(c)
+ def test_all_failure_classes(self):
+ failure_classes = (
+ FailureTimeout,
+ FailureCrash,
+ FailureMissingResult,
+ FailureNotTested,
+ FailureTextMismatch,
+ FailureMissingImageHash,
+ FailureMissingImage,
+ FailureImageHashMismatch,
+ FailureImageHashIncorrect,
+ FailureReftestMismatch,
+ FailureReftestMismatchDidNotOccur,
+ FailureReftestNoImagesGenerated,
+ FailureMissingAudio,
+ FailureAudioMismatch,
+ FailureDocumentLeak,
+ FailureEarlyExit)
+ self.assertEqual(failure_classes, ALL_FAILURE_CLASSES)
+
def test_equals(self):
self.assertEqual(FailureCrash(), FailureCrash())
self.assertNotEqual(FailureCrash(), FailureTimeout())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
