Title: [235509] trunk/Tools
- Revision
- 235509
- Author
- [email protected]
- Date
- 2018-08-30 10:03:01 -0700 (Thu, 30 Aug 2018)
Log Message
WKNavigation.ProcessCrashDuringCallback is failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=189148
Reviewed by Chris Dumez.
We should not deference WebView or we may get WKErrorWebViewInvalidated error, because
WebView could be destroyed before Web Process termination is noticed.
* TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235508 => 235509)
--- trunk/Tools/ChangeLog 2018-08-30 16:53:01 UTC (rev 235508)
+++ trunk/Tools/ChangeLog 2018-08-30 17:03:01 UTC (rev 235509)
@@ -1,3 +1,16 @@
+2018-08-30 Sihui Liu <[email protected]>
+
+ WKNavigation.ProcessCrashDuringCallback is failing on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=189148
+
+ Reviewed by Chris Dumez.
+
+ We should not deference WebView or we may get WKErrorWebViewInvalidated error, because
+ WebView could be destroyed before Web Process termination is noticed.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
+ (TEST):
+
2018-08-30 Zalan Bujtas <[email protected]>
[LFC][Floating] Formatting context roots avoid floats.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm (235508 => 235509)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-30 16:53:01 UTC (rev 235508)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-30 17:03:01 UTC (rev 235509)
@@ -275,8 +275,6 @@
// Simulate a crash, which should invalidate all pending callbacks.
[webView _killWebContentProcess];
- webView = nullptr;
-
TestWebKitAPI::Util::run(&calledAllCallbacks);
TestWebKitAPI::Util::sleep(0.5);
EXPECT_EQ(6U, callbackCount);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
