Title: [101514] trunk/Source/WebKit2
- Revision
- 101514
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-30 07:32:04 -0800 (Wed, 30 Nov 2011)
Log Message
[Gtk] Links should be Tab-focusable by default
https://bugs.webkit.org/show_bug.cgi?id=73427
Patch by Mario Sanchez Prada <msanc...@igalia.com> on 2011-11-30
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init): Switch the default value for
'enable-tabs-to-links' property from FALSE to TRUE.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Updated unit test.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (101513 => 101514)
--- trunk/Source/WebKit2/ChangeLog 2011-11-30 15:28:02 UTC (rev 101513)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-30 15:32:04 UTC (rev 101514)
@@ -1,3 +1,16 @@
+2011-11-30 Mario Sanchez Prada <msanc...@igalia.com>
+
+ [Gtk] Links should be Tab-focusable by default
+ https://bugs.webkit.org/show_bug.cgi?id=73427
+
+ Reviewed by Martin Robinson.
+
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ (webkit_settings_class_init): Switch the default value for
+ 'enable-tabs-to-links' property from FALSE to TRUE.
+ * UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
+ (testWebKitSettings): Updated unit test.
+
2011-11-30 Alexey Proskuryakov <a...@apple.com>
Download page URL should be set by WebCore
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (101513 => 101514)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-11-30 15:28:02 UTC (rev 101513)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-11-30 15:32:04 UTC (rev 101514)
@@ -691,7 +691,7 @@
g_param_spec_boolean("enable-tabs-to-links",
_("Enable tabs to links"),
_("Whether to enable tabs to links"),
- FALSE,
+ TRUE,
readWriteConstructParamFlags));
/**
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp (101513 => 101514)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp 2011-11-30 15:28:02 UTC (rev 101513)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp 2011-11-30 15:32:04 UTC (rev 101514)
@@ -169,9 +169,9 @@
webkit_settings_set_enable_resizable_text_areas(settings, FALSE);
g_assert(!webkit_settings_get_enable_resizable_text_areas(settings));
+ g_assert(webkit_settings_get_enable_tabs_to_links(settings));
+ webkit_settings_set_enable_tabs_to_links(settings, FALSE);
g_assert(!webkit_settings_get_enable_tabs_to_links(settings));
- webkit_settings_set_enable_tabs_to_links(settings, TRUE);
- g_assert(webkit_settings_get_enable_tabs_to_links(settings));
// Caret browsing is disabled by default.
g_assert(!webkit_settings_get_enable_caret_browsing(settings));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
