Title: [235198] trunk/Source/_javascript_Core
Revision
235198
Author
msab...@apple.com
Date
2018-08-22 13:42:17 -0700 (Wed, 22 Aug 2018)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=188859
Eliminate dead code operationThrowDivideError() and operationThrowOutOfBoundsAccessError()

Rubber-stamped by Saam Barati.

Deleted these two functions.

* jit/JITOperations.cpp:
* jit/JITOperations.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (235197 => 235198)


--- trunk/Source/_javascript_Core/ChangeLog	2018-08-22 20:40:22 UTC (rev 235197)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-08-22 20:42:17 UTC (rev 235198)
@@ -1,3 +1,15 @@
+2018-08-22  Michael Saboff  <msab...@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=188859
+        Eliminate dead code operationThrowDivideError() and operationThrowOutOfBoundsAccessError()
+
+        Rubber-stamped by Saam Barati.
+
+        Deleted these two functions.
+
+        * jit/JITOperations.cpp:
+        * jit/JITOperations.h:
+
 2018-08-22  Mark Lam  <mark....@apple.com>
 
         The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.

Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (235197 => 235198)


--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2018-08-22 20:40:22 UTC (rev 235197)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2018-08-22 20:42:17 UTC (rev 235198)
@@ -114,34 +114,6 @@
     throwStackOverflowError(callerFrame, scope);
 }
 
-#if ENABLE(WEBASSEMBLY)
-void JIT_OPERATION operationThrowDivideError(ExecState* exec)
-{
-    VM* vm = &exec->vm();
-    auto scope = DECLARE_THROW_SCOPE(*vm);
-
-    EntryFrame* entryFrame = vm->topEntryFrame;
-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
-
-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
-    ErrorHandlingScope errorScope(*vm);
-    throwException(callerFrame, scope, createError(callerFrame, "Division by zero or division overflow."_s));
-}
-
-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState* exec)
-{
-    VM* vm = &exec->vm();
-    auto scope = DECLARE_THROW_SCOPE(*vm);
-
-    EntryFrame* entryFrame = vm->topEntryFrame;
-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
-
-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
-    ErrorHandlingScope errorScope(*vm);
-    throwException(callerFrame, scope, createError(callerFrame, "Out-of-bounds access."_s));
-}
-#endif
-
 int32_t JIT_OPERATION operationCallArityCheck(ExecState* exec)
 {
     VM* vm = &exec->vm();

Modified: trunk/Source/_javascript_Core/jit/JITOperations.h (235197 => 235198)


--- trunk/Source/_javascript_Core/jit/JITOperations.h	2018-08-22 20:40:22 UTC (rev 235197)
+++ trunk/Source/_javascript_Core/jit/JITOperations.h	2018-08-22 20:42:17 UTC (rev 235198)
@@ -353,10 +353,6 @@
 void JIT_OPERATION operationVMHandleException(ExecState*) WTF_INTERNAL;
 
 void JIT_OPERATION operationThrowStackOverflowError(ExecState*, CodeBlock*) WTF_INTERNAL;
-#if ENABLE(WEBASSEMBLY)
-void JIT_OPERATION operationThrowDivideError(ExecState*) WTF_INTERNAL;
-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState*) WTF_INTERNAL;
-#endif
 int32_t JIT_OPERATION operationCallArityCheck(ExecState*) WTF_INTERNAL;
 int32_t JIT_OPERATION operationConstructArityCheck(ExecState*) WTF_INTERNAL;
 EncodedJSValue JIT_OPERATION operationTryGetById(ExecState*, StructureStubInfo*, EncodedJSValue, UniquedStringImpl*) WTF_INTERNAL;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to