Title: [235021] trunk/Source/_javascript_Core
- Revision
- 235021
- Author
- [email protected]
- Date
- 2018-08-19 17:24:47 -0700 (Sun, 19 Aug 2018)
Log Message
Unreviewed, rolling out r234852.
https://bugs.webkit.org/show_bug.cgi?id=188736
Workaround is not correct (Requested by yusukesuzuki on
#webkit).
Reverted changeset:
"[JSC] Should not rotate constant with 64"
https://bugs.webkit.org/show_bug.cgi?id=188556
https://trac.webkit.org/changeset/234852
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (235020 => 235021)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-19 23:59:12 UTC (rev 235020)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-20 00:24:47 UTC (rev 235021)
@@ -1,3 +1,17 @@
+2018-08-19 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r234852.
+ https://bugs.webkit.org/show_bug.cgi?id=188736
+
+ Workaround is not correct (Requested by yusukesuzuki on
+ #webkit).
+
+ Reverted changeset:
+
+ "[JSC] Should not rotate constant with 64"
+ https://bugs.webkit.org/show_bug.cgi?id=188556
+ https://trac.webkit.org/changeset/234852
+
2018-08-19 Yusuke Suzuki <[email protected]>
[WTF] Add WTF::unalignedLoad and WTF::unalignedStore
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (235020 => 235021)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2018-08-19 23:59:12 UTC (rev 235020)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2018-08-20 00:24:47 UTC (rev 235021)
@@ -1290,13 +1290,6 @@
return shouldBlindPointerForSpecificArch(value);
}
-
- uint8_t generateRotationSeed(size_t widthInBits)
- {
- // Generate the seed in [0, widthInBits). We should not generate widthInBits
- // since it leads to `<< widthInBits`, which is an undefined behavior.
- return random() % (widthInBits - 1);
- }
struct RotatedImmPtr {
RotatedImmPtr(uintptr_t v1, uint8_t v2)
@@ -1310,7 +1303,7 @@
RotatedImmPtr rotationBlindConstant(ImmPtr imm)
{
- uint8_t rotation = generateRotationSeed(sizeof(void*) * 8);
+ uint8_t rotation = random() % (sizeof(void*) * 8);
uintptr_t value = imm.asTrustedImmPtr().asIntptr();
value = (value << rotation) | (value >> (sizeof(void*) * 8 - rotation));
return RotatedImmPtr(value, rotation);
@@ -1378,7 +1371,7 @@
RotatedImm64 rotationBlindConstant(Imm64 imm)
{
- uint8_t rotation = generateRotationSeed(sizeof(int64_t) * 8);
+ uint8_t rotation = random() % (sizeof(int64_t) * 8);
uint64_t value = imm.asTrustedImm64().m_value;
value = (value << rotation) | (value >> (sizeof(int64_t) * 8 - rotation));
return RotatedImm64(value, rotation);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
