Title: [101450] trunk/Source
Revision
101450
Author
[email protected]
Date
2011-11-29 22:03:13 -0800 (Tue, 29 Nov 2011)

Log Message

Remove RetainPtr::releaseRef
https://bugs.webkit.org/show_bug.cgi?id=73396

Reviewed by Dan Bernstein.

../_javascript_Core: 

* wtf/RetainPtr.h:
Be gone releaseRef! Long live leakRef!

../WebKit2: 

* Platform/mac/ModuleMac.mm:
(WebKit::Module::unload):
Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
its sexy replacement.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101449 => 101450)


--- trunk/Source/_javascript_Core/ChangeLog	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-30 06:03:13 UTC (rev 101450)
@@ -1,5 +1,15 @@
 2011-11-29  Sam Weinig  <[email protected]>
 
+        Remove RetainPtr::releaseRef
+        https://bugs.webkit.org/show_bug.cgi?id=73396
+
+        Reviewed by Dan Bernstein.
+
+        * wtf/RetainPtr.h:
+        Be gone releaseRef! Long live leakRef!
+
+2011-11-29  Sam Weinig  <[email protected]>
+
         Add move semantics to RetainPtr
         https://bugs.webkit.org/show_bug.cgi?id=73393
 

Modified: trunk/Source/_javascript_Core/wtf/RetainPtr.h (101449 => 101450)


--- trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 06:03:13 UTC (rev 101450)
@@ -109,9 +109,6 @@
         
         void swap(RetainPtr&);
 
-        // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
-        PtrType releaseRef() { return leakRef(); }
-
     private:
         static PtrType hashTableDeletedValue() { return reinterpret_cast<PtrType>(-1); }
 

Modified: trunk/Source/WebKit2/ChangeLog (101449 => 101450)


--- trunk/Source/WebKit2/ChangeLog	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-30 06:03:13 UTC (rev 101450)
@@ -1,3 +1,15 @@
+2011-11-29  Sam Weinig  <[email protected]>
+
+        Remove RetainPtr::releaseRef
+        https://bugs.webkit.org/show_bug.cgi?id=73396
+
+        Reviewed by Dan Bernstein.
+
+        * Platform/mac/ModuleMac.mm:
+        (WebKit::Module::unload):
+        Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
+        its sexy replacement.
+
 2011-11-29  Jessie Berlin  <[email protected]>
 
         WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins

Modified: trunk/Source/WebKit2/Platform/mac/ModuleMac.mm (101449 => 101450)


--- trunk/Source/WebKit2/Platform/mac/ModuleMac.mm	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/WebKit2/Platform/mac/ModuleMac.mm	2011-11-30 06:03:13 UTC (rev 101450)
@@ -57,7 +57,7 @@
 #endif
 
     // See the comment in Module.h for why we leak the bundle here.
-    m_bundle.releaseRef();
+    (void)m_bundle.leakRef();
 }
 
 void* Module::platformFunctionPointer(const char* functionName) const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to