Title: [101240] trunk/Tools
- Revision
- 101240
- Author
- [email protected]
- Date
- 2011-11-28 02:23:02 -0800 (Mon, 28 Nov 2011)
Log Message
run-bindings-tests shows diff error for a newly added binding test
https://bugs.webkit.org/show_bug.cgi?id=73179
Reviewed by Adam Barth.
Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
run-bindings-tests just shows diff error because reference files
(i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
FAIL: (V8) V8TestSupplemental.h
diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
Instead, this patch treats a non-existent reference file as an empty file and
shows the result of the newly added binding test, like this:
FAIL: (V8) V8TestSupplemental.h
--- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h 1970-01-01 09:00:00.000000000 +0900
+++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
@@ -0,0 +1,84 @@
+/*
+ This file is part of the WebKit open source project.
+ This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+
(omitted)
* Scripts/run-bindings-tests:
(detect_changes): Just added an -N option to the diff command.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (101239 => 101240)
--- trunk/Tools/ChangeLog 2011-11-28 10:09:32 UTC (rev 101239)
+++ trunk/Tools/ChangeLog 2011-11-28 10:23:02 UTC (rev 101240)
@@ -1,3 +1,33 @@
+2011-11-28 Kentaro Hara <[email protected]>
+
+ run-bindings-tests shows diff error for a newly added binding test
+ https://bugs.webkit.org/show_bug.cgi?id=73179
+
+ Reviewed by Adam Barth.
+
+ Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
+ run-bindings-tests just shows diff error because reference files
+ (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
+
+ FAIL: (V8) V8TestSupplemental.h
+ diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
+
+ Instead, this patch treats a non-existent reference file as an empty file and
+ shows the result of the newly added binding test, like this:
+
+ FAIL: (V8) V8TestSupplemental.h
+ --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h 1970-01-01 09:00:00.000000000 +0900
+ +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
+ @@ -0,0 +1,84 @@
+ +/*
+ + This file is part of the WebKit open source project.
+ + This file has been generated by generate-bindings.pl. DO NOT MODIFY!
+ +
+ (omitted)
+
+ * Scripts/run-bindings-tests:
+ (detect_changes): Just added an -N option to the diff command.
+
2011-11-28 Martin Robinson <[email protected]>
[Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
Modified: trunk/Tools/Scripts/run-bindings-tests (101239 => 101240)
--- trunk/Tools/Scripts/run-bindings-tests 2011-11-28 10:09:32 UTC (rev 101239)
+++ trunk/Tools/Scripts/run-bindings-tests 2011-11-28 10:23:02 UTC (rev 101240)
@@ -62,6 +62,7 @@
for output_file in os.listdir(work_directory):
cmd = ['diff',
'-u',
+ '-N',
os.path.join(reference_directory, output_file),
os.path.join(work_directory, output_file)]
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
