Title: [231929] trunk/Source/WebCore
- Revision
- 231929
- Author
- [email protected]
- Date
- 2018-05-17 16:03:50 -0700 (Thu, 17 May 2018)
Log Message
Remove unnecessary exit fullscreen call on application resume
https://bugs.webkit.org/show_bug.cgi?id=185747
rdar://problem/40345725
Patch by Jeremy Jones <[email protected]> on 2018-05-17
Reviewed by Jer Noble.
No new tests because no behavior change.
Auto-PiP doesn't automatically return to fullscreen on app resume,
so we don't need to keep this vestigial code for handling a corner case of that feature.
Also, this can cause an unnecessary exit fullscreen that could cause debug asserts.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::applicationDidBecomeActive):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (231928 => 231929)
--- trunk/Source/WebCore/ChangeLog 2018-05-17 22:42:26 UTC (rev 231928)
+++ trunk/Source/WebCore/ChangeLog 2018-05-17 23:03:50 UTC (rev 231929)
@@ -1,5 +1,22 @@
2018-05-17 Jeremy Jones <[email protected]>
+ Remove unnecessary exit fullscreen call on application resume
+ https://bugs.webkit.org/show_bug.cgi?id=185747
+ rdar://problem/40345725
+
+ Reviewed by Jer Noble.
+
+ No new tests because no behavior change.
+
+ Auto-PiP doesn't automatically return to fullscreen on app resume,
+ so we don't need to keep this vestigial code for handling a corner case of that feature.
+ Also, this can cause an unnecessary exit fullscreen that could cause debug asserts.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (VideoFullscreenInterfaceAVKit::applicationDidBecomeActive):
+
+2018-05-17 Jeremy Jones <[email protected]>
+
Fullscreen to PiP results in exit fullscreen call failure
https://bugs.webkit.org/show_bug.cgi?id=185699
rdar://problem/40310291
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (231928 => 231929)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-05-17 22:42:26 UTC (rev 231928)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-05-17 23:03:50 UTC (rev 231929)
@@ -1288,15 +1288,6 @@
void VideoFullscreenInterfaceAVKit::applicationDidBecomeActive()
{
LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::applicationDidBecomeActive(%p)", this);
-
- // If we are both in PiP and in Fullscreen (i.e., via auto-PiP), and we did not stop fullscreen upon returning, it must be
- // because the originating view is not visible, so hide the fullscreen window.
- if (m_currentMode.hasFullscreen() && m_currentMode.hasPictureInPicture()) {
- [[m_playerViewController view] layoutIfNeeded];
- [m_playerViewController exitFullScreenAnimated:NO completionHandler:[protectedThis = makeRefPtr(this), this] (BOOL success, NSError *error) {
- exitFullscreenHandler(success, error);
- }];
- }
}
void VideoFullscreenInterfaceAVKit::setupFullscreen(UIView& videoView, const IntRect& initialRect, UIView* parentView, HTMLMediaElementEnums::VideoFullscreenMode mode, bool allowsPictureInPicturePlayback, bool standby)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
