Title: [229843] trunk/Source/WebCore
- Revision
- 229843
- Author
- [email protected]
- Date
- 2018-03-21 20:14:14 -0700 (Wed, 21 Mar 2018)
Log Message
Regression(r229828): WebKit.NoHistoryItemScrollToFragment API test is failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=183886
Reviewed by Wenson Hsieh.
Since r229828, the FrameLoader needs to call FrameLoaderClient::didDecidePolicyForNavigationAction()
whenever a navigation policy decision is made. I added such a call r229828 to
FrameLoader::continueLoadAfterNavigationPolicy() but forgot to add one to
FrameLoader::continueFragmentScrollAfterNavigationPolicy(), which is the equivalent
for fragment navigations.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (229842 => 229843)
--- trunk/Source/WebCore/ChangeLog 2018-03-22 02:15:44 UTC (rev 229842)
+++ trunk/Source/WebCore/ChangeLog 2018-03-22 03:14:14 UTC (rev 229843)
@@ -1,3 +1,19 @@
+2018-03-21 Chris Dumez <[email protected]>
+
+ Regression(r229828): WebKit.NoHistoryItemScrollToFragment API test is failing on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=183886
+
+ Reviewed by Wenson Hsieh.
+
+ Since r229828, the FrameLoader needs to call FrameLoaderClient::didDecidePolicyForNavigationAction()
+ whenever a navigation policy decision is made. I added such a call r229828 to
+ FrameLoader::continueLoadAfterNavigationPolicy() but forgot to add one to
+ FrameLoader::continueFragmentScrollAfterNavigationPolicy(), which is the equivalent
+ for fragment navigations.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
+
2018-03-21 Said Abou-Hallawa <[email protected]>
Disconnect the SVGPathSegList items from their SVGPathElement before rebuilding a new list
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (229842 => 229843)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2018-03-22 02:15:44 UTC (rev 229842)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2018-03-22 03:14:14 UTC (rev 229843)
@@ -2922,6 +2922,8 @@
void FrameLoader::continueFragmentScrollAfterNavigationPolicy(const ResourceRequest& request, bool shouldContinue)
{
+ m_client.didDecidePolicyForNavigationAction();
+
m_quickRedirectComing = false;
if (!shouldContinue)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
