Title: [229841] trunk/Source/WebKit
- Revision
- 229841
- Author
- [email protected]
- Date
- 2018-03-21 18:49:27 -0700 (Wed, 21 Mar 2018)
Log Message
Regression(r229831): ProcessSwap.Basic API test is crashing
https://bugs.webkit.org/show_bug.cgi?id=183884
Reviewed by Brady Eidson.
This code should only be called for navigation policy decisions.
It used to work without this check because of an early return, which
was dropped in r229831.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (229840 => 229841)
--- trunk/Source/WebKit/ChangeLog 2018-03-22 01:47:43 UTC (rev 229840)
+++ trunk/Source/WebKit/ChangeLog 2018-03-22 01:49:27 UTC (rev 229841)
@@ -1,3 +1,17 @@
+2018-03-21 Chris Dumez <[email protected]>
+
+ Regression(r229831): ProcessSwap.Basic API test is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=183884
+
+ Reviewed by Brady Eidson.
+
+ This code should only be called for navigation policy decisions.
+ It used to work without this check because of an early return, which
+ was dropped in r229831.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::receivedPolicyDecision):
+
2018-03-21 Wenson Hsieh <[email protected]>
[Extra zoom mode] Add new SPI hooks for clients to vend an input session context view
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (229840 => 229841)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-03-22 01:47:43 UTC (rev 229840)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-03-22 01:49:27 UTC (rev 229841)
@@ -2369,7 +2369,7 @@
}
auto* activePolicyListener = frame.activePolicyListenerProxy();
- if (activePolicyListener) {
+ if (activePolicyListener && activePolicyListener->policyListenerType() == PolicyListenerType::NavigationAction) {
ASSERT(activePolicyListener->listenerID() == listenerID);
if (action == PolicyAction::Use && navigation) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
