Title: [229430] trunk/Source/WebCore
Revision
229430
Author
[email protected]
Date
2018-03-08 13:30:27 -0800 (Thu, 08 Mar 2018)

Log Message

Ensure system appearance is default for legacy webkit
https://bugs.webkit.org/show_bug.cgi?id=183473
<rdar://problem/38210306>

Reviewed by Tim Horton.

Need to set the appearance on the window for legacy webkit due to differences in drawing.

Not currently testable, will add tests in a later patch.

* platform/mac/ThemeMac.mm:
(WebCore::paintButton):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (229429 => 229430)


--- trunk/Source/WebCore/ChangeLog	2018-03-08 21:25:10 UTC (rev 229429)
+++ trunk/Source/WebCore/ChangeLog	2018-03-08 21:30:27 UTC (rev 229430)
@@ -1,3 +1,18 @@
+2018-03-08  Megan Gardner  <[email protected]>
+
+        Ensure system appearance is default for legacy webkit
+        https://bugs.webkit.org/show_bug.cgi?id=183473
+        <rdar://problem/38210306>
+
+        Reviewed by Tim Horton.
+
+        Need to set the appearance on the window for legacy webkit due to differences in drawing.
+
+        Not currently testable, will add tests in a later patch.
+
+        * platform/mac/ThemeMac.mm:
+        (WebCore::paintButton):
+
 2018-03-08  Youenn Fablet  <[email protected]>
 
         libwebrtc update broke internal builds

Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (229429 => 229430)


--- trunk/Source/WebCore/platform/mac/ThemeMac.mm	2018-03-08 21:25:10 UTC (rev 229429)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm	2018-03-08 21:30:27 UTC (rev 229430)
@@ -565,6 +565,8 @@
     
     NSView *view = ThemeMac::ensuredView(scrollView, controlStates);
     NSWindow *window = [view window];
+    LocalDefaultSystemAppearance localAppearence;
+    [window setAppearance:[NSAppearance currentAppearance]];
     NSButtonCell *previousDefaultButtonCell = [window defaultButtonCell];
 
     bool useImageBuffer = pageScaleFactor != 1.0f || zoomFactor != 1.0f;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to