Title: [229409] trunk/Source/WTF
- Revision
- 229409
- Author
- [email protected]
- Date
- 2018-03-08 07:47:21 -0800 (Thu, 08 Mar 2018)
Log Message
[Win] Use __debugbreak for WTFBreakpointTrap
https://bugs.webkit.org/show_bug.cgi?id=183450
Reviewed by Mark Lam.
This patch adds WTFBreakpointTrap() implementation for MSVC by using
__debugbreak. It fixes build failure in Windows due to the use of
WTFBreakpointTrap().
* wtf/Assertions.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (229408 => 229409)
--- trunk/Source/WTF/ChangeLog 2018-03-08 15:06:04 UTC (rev 229408)
+++ trunk/Source/WTF/ChangeLog 2018-03-08 15:47:21 UTC (rev 229409)
@@ -1,3 +1,16 @@
+2018-03-08 Yusuke Suzuki <[email protected]>
+
+ [Win] Use __debugbreak for WTFBreakpointTrap
+ https://bugs.webkit.org/show_bug.cgi?id=183450
+
+ Reviewed by Mark Lam.
+
+ This patch adds WTFBreakpointTrap() implementation for MSVC by using
+ __debugbreak. It fixes build failure in Windows due to the use of
+ WTFBreakpointTrap().
+
+ * wtf/Assertions.h:
+
2018-03-08 Zan Dobersek <[email protected]>
[GLib] RunLoop::wakeUp(): use a zero value instead of the monotonic time
Modified: trunk/Source/WTF/wtf/Assertions.h (229408 => 229409)
--- trunk/Source/WTF/wtf/Assertions.h 2018-03-08 15:06:04 UTC (rev 229408)
+++ trunk/Source/WTF/wtf/Assertions.h 2018-03-08 15:47:21 UTC (rev 229409)
@@ -206,7 +206,9 @@
WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached(void);
-#if ASAN_ENABLED
+#if COMPILER(MSVC)
+#define WTFBreakpointTrap() __debugbreak()
+#elif ASAN_ENABLED
#define WTFBreakpointTrap() __builtin_trap()
#elif CPU(X86_64) || CPU(X86)
#define WTFBreakpointTrap() __asm__ volatile ("int3")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
