Title: [228539] trunk/Tools
- Revision
- 228539
- Author
- a...@apple.com
- Date
- 2018-02-15 16:07:23 -0800 (Thu, 15 Feb 2018)
Log Message
Speed up dSYM generation on build.webkit.org with -gline-tables-only
https://bugs.webkit.org/show_bug.cgi?id=182841
rdar://problem/34579649
Reviewed by Aakash Jain.
Build speed and binary size improvements are so substantial that I'm willing to make
CI builds less suitable for debugging, which is not a common scenario anyway.
Crash logs will still have line numbers in them.
* BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (228538 => 228539)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-02-15 23:38:15 UTC (rev 228538)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-02-16 00:07:23 UTC (rev 228539)
@@ -206,10 +206,12 @@
self.setCommand(self.command + ['ARCHS=' + architecture])
if platform == 'ios':
self.setCommand(self.command + ['_ONLY_ACTIVE_ARCH_=NO'])
- # Generating dSYM files is slow, but these are needed to have line numbers in crash reports on testers.
- # Debug builds on Yosemite can't use dSYMs, because crash logs end up unsymbolicated.
- if platform in ('mac', 'ios') and buildOnly and (self.getProperty('fullPlatform') != "mac-yosemite" or self.getProperty('configuration') != "debug"):
+ if platform in ('mac', 'ios') and buildOnly:
+ # For build-only bots, the expectation is that tests will be run on separate machines,
+ # so we need to package debug info as dSYMs. Only generating line tables makes
+ # this much faster than full debug info, and crash logs still have line numbers.
self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym'])
+ self.setCommand(self.command + ['CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only'])
appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
Modified: trunk/Tools/ChangeLog (228538 => 228539)
--- trunk/Tools/ChangeLog 2018-02-15 23:38:15 UTC (rev 228538)
+++ trunk/Tools/ChangeLog 2018-02-16 00:07:23 UTC (rev 228539)
@@ -1,3 +1,17 @@
+2018-02-15 Alexey Proskuryakov <a...@apple.com>
+
+ Speed up dSYM generation on build.webkit.org with -gline-tables-only
+ https://bugs.webkit.org/show_bug.cgi?id=182841
+ rdar://problem/34579649
+
+ Reviewed by Aakash Jain.
+
+ Build speed and binary size improvements are so substantial that I'm willing to make
+ CI builds less suitable for debugging, which is not a common scenario anyway.
+ Crash logs will still have line numbers in them.
+
+ * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
+
2018-02-15 Don Olmstead <don.olmst...@sony.com>
WebCore headers should not be included relatively within dependent projects
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
