Title: [225955] trunk/Source/WebCore
- Revision
- 225955
- Author
- [email protected]
- Date
- 2017-12-14 18:14:04 -0800 (Thu, 14 Dec 2017)
Log Message
srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes if getUserMedia access has not been granted
https://bugs.webkit.org/show_bug.cgi?id=180842
Patch by Youenn Fablet <[email protected]> on 2017-12-14
Reviewed by Jon Lee.
Manually tested since there is no way to gather reflexive or stun candidates in WebKit CI.
* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::filterICECandidate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (225954 => 225955)
--- trunk/Source/WebCore/ChangeLog 2017-12-15 02:08:23 UTC (rev 225954)
+++ trunk/Source/WebCore/ChangeLog 2017-12-15 02:14:04 UTC (rev 225955)
@@ -1,3 +1,15 @@
+2017-12-14 Youenn Fablet <[email protected]>
+
+ srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes if getUserMedia access has not been granted
+ https://bugs.webkit.org/show_bug.cgi?id=180842
+
+ Reviewed by Jon Lee.
+
+ Manually tested since there is no way to gather reflexive or stun candidates in WebKit CI.
+
+ * Modules/mediastream/PeerConnectionBackend.cpp:
+ (WebCore::filterICECandidate):
+
2017-12-14 Commit Queue <[email protected]>
Unreviewed, rolling out r225878.
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (225954 => 225955)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-12-15 02:08:23 UTC (rev 225954)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-12-15 02:14:04 UTC (rev 225955)
@@ -336,10 +336,16 @@
skipNextItem = false;
return;
}
- if (item == "raddr" || item == "rport") {
+ if (item == "raddr") {
+ filteredSDP.append(" raddr 0.0.0.0");
skipNextItem = true;
return;
}
+ if (item == "rport") {
+ filteredSDP.append(" rport 0");
+ skipNextItem = true;
+ return;
+ }
if (isFirst)
isFirst = false;
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
