Title: [225508] trunk/Source/WebKit
Revision
225508
Author
bfulg...@apple.com
Date
2017-12-04 17:11:52 -0800 (Mon, 04 Dec 2017)

Log Message

Don't force creation of process pool when enabling resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (225507 => 225508)


--- trunk/Source/WebKit/ChangeLog	2017-12-05 00:57:33 UTC (rev 225507)
+++ trunk/Source/WebKit/ChangeLog	2017-12-05 01:11:52 UTC (rev 225508)
@@ -1,3 +1,19 @@
+2017-12-04  Brent Fulgham  <bfulg...@apple.com>
+
+        Don't force creation of process pool when enabling resource load statistics
+        https://bugs.webkit.org/show_bug.cgi?id=180374
+        <rdar://problem/35545639>
+
+        Reviewed by Alex Christensen.
+
+        Pass appropriate arguments to the 'processPool' accessor so that we only get the
+        set of existing process pools. We don't want to pay the cost of launching new
+        process pools just to set this flag. The flag will be properly set when the pools
+        are created as soon as a WebView is instantiated.
+
+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+        (WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
+
 2017-12-04  David Quesada  <david_ques...@apple.com>
 
         Add a class for parsing application manifests

Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (225507 => 225508)


--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	2017-12-05 00:57:33 UTC (rev 225507)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	2017-12-05 01:11:52 UTC (rev 225508)
@@ -1326,7 +1326,9 @@
     }
 
     m_resourceLoadStatistics = nullptr;
-    for (auto& processPool : processPools())
+
+    auto existingProcessPools = processPools(std::numeric_limits<size_t>::max(), false);
+    for (auto& processPool : existingProcessPools)
         processPool->setResourceLoadStatisticsEnabled(false);
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to