Diff
Modified: trunk/Tools/ChangeLog (224687 => 224688)
--- trunk/Tools/ChangeLog 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/ChangeLog 2017-11-10 17:39:51 UTC (rev 224688)
@@ -1,3 +1,18 @@
+2017-11-10 Aakash Jain <aakash_j...@apple.com>
+
+ fix style failures in webkitpy: expected 2 blank lines found 1
+ https://bugs.webkit.org/show_bug.cgi?id=179529
+
+ Reviewed by Alex Christensen.
+
+ * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
+ * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
+ * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
+ * Scripts/webkitpy/common/version.py: Ditto.
+ * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
+ * Scripts/webkitpy/port/mac_unittest.py: Ditto.
+ * Scripts/webkitpy/port/simulator_process.py: Ditto.
+
2017-11-10 Alex Christensen <achristen...@webkit.org>
REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -8,6 +8,7 @@
_log = logging.getLogger(__name__)
+
class OSXChromeDriver(OSXBrowserDriver):
process_name = 'Google Chrome'
browser_name = 'chrome'
@@ -59,6 +60,7 @@
args = ['--args', '--homepage', create_window_size_arg()]
return args
+
def create_chrome_options():
from selenium.webdriver.chrome.options import Options
chrome_options = Options()
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -61,6 +61,7 @@
return args
+
def run_benchmark_plan(args, plan):
benchmark_runner_class = benchmark_runner_subclasses[args.driver]
runner = benchmark_runner_class(plan, args.local_copy, args.count, args.build_dir, args.output_file, args.platform, args.browser, args.scale_unit, args.device_id)
@@ -72,6 +73,7 @@
for plan in BenchmarkRunner.available_plans():
print "\t%s" % plan
+
def start(args):
if args.json_file:
results_json = json.load(open(args.json_file, 'r'))
Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -29,6 +29,7 @@
from webkitpy.common.version import Version
+
class MockPlatformInfo(object):
def __init__(self, os_name='mac', os_version='snowleopard'):
self.os_name = os_name
Modified: trunk/Tools/Scripts/webkitpy/common/version.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/common/version.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/common/version.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -22,6 +22,7 @@
import collections
+
class Version(object):
def __init__(self, ver='0'):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -169,6 +169,7 @@
def message(self):
return 'test was not run'
+
class FailureTextMismatch(FailureText):
def message(self):
return "text diff"
Modified: trunk/Tools/Scripts/webkitpy/port/mac_unittest.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/port/mac_unittest.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/port/mac_unittest.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -36,6 +36,7 @@
from webkitpy.tool.mocktool import MockOptions
from webkitpy.common.system.executive_mock import MockExecutive, MockExecutive2, ScriptError
+
class MacTest(darwin_testcase.DarwinTest):
os_name = 'mac'
os_version = 'lion'
Modified: trunk/Tools/Scripts/webkitpy/port/simulator_process.py (224687 => 224688)
--- trunk/Tools/Scripts/webkitpy/port/simulator_process.py 2017-11-10 17:30:59 UTC (rev 224687)
+++ trunk/Tools/Scripts/webkitpy/port/simulator_process.py 2017-11-10 17:39:51 UTC (rev 224688)
@@ -27,6 +27,7 @@
from webkitpy.common.timeout_context import Timeout
from webkitpy.port.server_process import ServerProcess
+
class SimulatorProcess(ServerProcess):
class Popen(object):
