Title: [221254] releases/WebKitGTK/webkit-2.18/Source/WebCore
- Revision
- 221254
- Author
- [email protected]
- Date
- 2017-08-28 06:39:11 -0700 (Mon, 28 Aug 2017)
Log Message
Merge r221008 - GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
https://bugs.webkit.org/show_bug.cgi?id=175819
Reviewed by Xabier Rodriguez-Calvar.
* platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is
allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog (221253 => 221254)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-28 13:38:28 UTC (rev 221253)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-28 13:39:11 UTC (rev 221254)
@@ -1,3 +1,17 @@
+2017-08-22 Zan Dobersek <[email protected]>
+
+ GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
+ https://bugs.webkit.org/show_bug.cgi?id=175819
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is
+ allocated on heap, so the embedded GLContext pointer can contain a
+ non-null value that can cause problems when e.g. checking for a current
+ GLContext on some specific thread on which a GLContext hasn't yet been
+ made current. Zero-initializing this pointer will avoid false positives
+ that can occur in these circumstances.
+
2017-08-21 Daniel Bates <[email protected]>
Cleanup TextPainter
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/graphics/GLContext.cpp (221253 => 221254)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/graphics/GLContext.cpp 2017-08-28 13:38:28 UTC (rev 221253)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/graphics/GLContext.cpp 2017-08-28 13:39:11 UTC (rev 221254)
@@ -50,7 +50,7 @@
GLContext* context() { return m_context; }
private:
- GLContext* m_context;
+ GLContext* m_context { nullptr };
};
ThreadSpecific<ThreadGlobalGLContext>* ThreadGlobalGLContext::staticGLContext;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
