Title: [221117] trunk/Tools
- Revision
- 221117
- Author
- [email protected]
- Date
- 2017-08-23 16:53:42 -0700 (Wed, 23 Aug 2017)
Log Message
Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
https://bugs.webkit.org/show_bug.cgi?id=175905
Reviewed by Tim Horton.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
so that the buffer can be destroyed.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221116 => 221117)
--- trunk/Tools/ChangeLog 2017-08-23 23:23:21 UTC (rev 221116)
+++ trunk/Tools/ChangeLog 2017-08-23 23:53:42 UTC (rev 221117)
@@ -1,3 +1,14 @@
+2017-08-23 Jonathan Bedard <[email protected]>
+
+ Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
+ https://bugs.webkit.org/show_bug.cgi?id=175905
+
+ Reviewed by Tim Horton.
+
+ * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+ (WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
+ so that the buffer can be destroyed.
+
2017-08-23 Alex Christensen <[email protected]>
Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
Modified: trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm (221116 => 221117)
--- trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2017-08-23 23:23:21 UTC (rev 221116)
+++ trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2017-08-23 23:53:42 UTC (rev 221117)
@@ -345,7 +345,7 @@
size_t rowBytes = CARenderServerGetBufferRowBytes(buffer);
static CGColorSpaceRef sRGBSpace = CGColorSpaceCreateWithName(kCGColorSpaceSRGB);
- RetainPtr<CGDataProviderRef> provider = adoptCF(CGDataProviderCreateWithData(0, data, CARenderServerGetBufferDataSize(buffer), releaseDataProviderData));
+ RetainPtr<CGDataProviderRef> provider = adoptCF(CGDataProviderCreateWithData(buffer, data, CARenderServerGetBufferDataSize(buffer), releaseDataProviderData));
RetainPtr<CGImageRef> cgImage = adoptCF(CGImageCreate(bufferWidth, bufferHeight, 8, 32, rowBytes, sRGBSpace, kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host, provider.get(), 0, false, kCGRenderingIntentDefault));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
