Title: [220671] releases/WebKitGTK/webkit-2.18/LayoutTests
- Revision
- 220671
- Author
- carlo...@webkit.org
- Date
- 2017-08-14 02:46:33 -0700 (Mon, 14 Aug 2017)
Log Message
Merge r220570 - Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>
Since accessibilityPress is async, we shouldn't rely on the timeout.
Reviewed by Chris Fleizach.
* accessibility/press-target-uses-text-descendant-node.html:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog (220670 => 220671)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-14 09:45:58 UTC (rev 220670)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-14 09:46:33 UTC (rev 220671)
@@ -1,5 +1,17 @@
2017-08-10 Nan Wang <n_w...@apple.com>
+ Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=175272
+ <rdar://problem/33756962>
+
+ Since accessibilityPress is async, we shouldn't rely on the timeout.
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/press-target-uses-text-descendant-node.html:
+
+2017-08-10 Nan Wang <n_w...@apple.com>
+
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/accessibility/press-target-uses-text-descendant-node.html (220670 => 220671)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/accessibility/press-target-uses-text-descendant-node.html 2017-08-14 09:45:58 UTC (rev 220670)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/accessibility/press-target-uses-text-descendant-node.html 2017-08-14 09:46:33 UTC (rev 220671)
@@ -38,20 +38,24 @@
description("Make sure that when performing a press, we target the deepest descendant, but also one that is an Element at the least.");
+ document.getElementById("link").addEventListener("click", pressedLink);
+ document.getElementById("button").addEventListener("click", pressedButton);
function startTest() {
accessibilityController.accessibleElementById("link").press();
- setTimeout(function() {
- debug("\nNow pressing on button\n");
- accessibilityController.accessibleElementById("button").press();
- setTimeout(function() {
- finishJSTest();
- }, 10);
- }, 10);
}
if (window.accessibilityController) {
window.jsTestIsAsync = true;
}
+
+ function pressedLink() {
+ debug("\nNow pressing on button\n");
+ accessibilityController.accessibleElementById("button").press();
+ }
+
+ function pressedButton() {
+ finishJSTest();
+ }
</script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes