Title: [220098] trunk/LayoutTests
Revision
220098
Author
da...@apple.com
Date
2017-08-01 09:13:55 -0700 (Tue, 01 Aug 2017)

Log Message

REGRESSION (r220052): http/tests/media/video-play-stall.html times out
https://bugs.webkit.org/show_bug.cgi?id=174988

Reviewed by Sam Weinig.

* TestExpectations: Stop skipping this test.

* http/tests/media/video-play-stall.html: Use a 0-duration timeout to sidestep an
issue where the test runner never thinks the test is done because of the stalled
media loading, and times out. The behaviors here aren't great, but there is no
reason to think that this confused state has any effect on web browsing; just on
our test runners in a test that intentionally has a still loading video in it.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (220097 => 220098)


--- trunk/LayoutTests/ChangeLog	2017-08-01 15:56:20 UTC (rev 220097)
+++ trunk/LayoutTests/ChangeLog	2017-08-01 16:13:55 UTC (rev 220098)
@@ -1,3 +1,18 @@
+2017-08-01  Darin Adler  <da...@apple.com>
+
+        REGRESSION (r220052): http/tests/media/video-play-stall.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=174988
+
+        Reviewed by Sam Weinig.
+
+        * TestExpectations: Stop skipping this test.
+
+        * http/tests/media/video-play-stall.html: Use a 0-duration timeout to sidestep an
+        issue where the test runner never thinks the test is done because of the stalled
+        media loading, and times out. The behaviors here aren't great, but there is no
+        reason to think that this confused state has any effect on web browsing; just on
+        our test runners in a test that intentionally has a still loading video in it.
+
 2017-08-01  Ms2ger  <ms2...@igalia.com>
 
         Correct the line numbers in GTK's scheme-about.any-expected.txt.

Modified: trunk/LayoutTests/TestExpectations (220097 => 220098)


--- trunk/LayoutTests/TestExpectations	2017-08-01 15:56:20 UTC (rev 220097)
+++ trunk/LayoutTests/TestExpectations	2017-08-01 16:13:55 UTC (rev 220098)
@@ -1398,5 +1398,3 @@
 webkit.org/b/172514 [ Debug ] imported/w3c/web-platform-tests/innerText/getter.html [ Skip ]
 
 webkit.org/b/173333 imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg [ Skip ]
-
-webkit.org/b/174988 http/tests/media/video-play-stall.html [ Skip ]

Modified: trunk/LayoutTests/http/tests/media/video-play-stall.html (220097 => 220098)


--- trunk/LayoutTests/http/tests/media/video-play-stall.html	2017-08-01 15:56:20 UTC (rev 220097)
+++ trunk/LayoutTests/http/tests/media/video-play-stall.html	2017-08-01 16:13:55 UTC (rev 220098)
@@ -38,7 +38,7 @@
 
         </script>
     </head>
-    <body _onload_="start()">
+    <body _onload_="setTimeout(start, 0)">
         <video controls></video>
         <p>Test that a stalled event is sent when media loading stalls.</p>
     </body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to