Title: [216788] trunk/Tools
- Revision
- 216788
- Author
- jbed...@apple.com
- Date
- 2017-05-12 13:37:46 -0700 (Fri, 12 May 2017)
Log Message
Unreviewed follow-up to r216776.
* Scripts/webkitpy/port/base.py:
(Port.path_to_crash_logs): Raise not implemented.
* Scripts/webkitpy/port/test.py:
(TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
* Scripts/webkitpy/port/win.py:
(WinPort.path_to_crash_logs): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (216787 => 216788)
--- trunk/Tools/ChangeLog 2017-05-12 20:32:23 UTC (rev 216787)
+++ trunk/Tools/ChangeLog 2017-05-12 20:37:46 UTC (rev 216788)
@@ -1,3 +1,14 @@
+2017-05-12 Jonathan Bedard <jbed...@apple.com>
+
+ Unreviewed follow-up to r216776.
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.path_to_crash_logs): Raise not implemented.
+ * Scripts/webkitpy/port/test.py:
+ (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
+ * Scripts/webkitpy/port/win.py:
+ (WinPort.path_to_crash_logs): Ditto.
+
2017-05-12 Alexey Proskuryakov <a...@apple.com>
Bot watcher's dashboard shows results links twice sometimes
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (216787 => 216788)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2017-05-12 20:32:23 UTC (rev 216787)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2017-05-12 20:37:46 UTC (rev 216788)
@@ -1348,7 +1348,7 @@
return driver.Driver
def path_to_crash_logs(self):
- return self.results_directory()
+ raise NotImplementedError
def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
name_str = name or '<unknown process name>'
Modified: trunk/Tools/Scripts/webkitpy/port/test.py (216787 => 216788)
--- trunk/Tools/Scripts/webkitpy/port/test.py 2017-05-12 20:32:23 UTC (rev 216787)
+++ trunk/Tools/Scripts/webkitpy/port/test.py 2017-05-12 20:37:46 UTC (rev 216788)
@@ -463,6 +463,9 @@
def _driver_class(self):
return TestDriver
+ def path_to_crash_logs(self):
+ return self.results_directory()
+
def start_http_server(self, additional_dirs=None):
pass
Modified: trunk/Tools/Scripts/webkitpy/port/win.py (216787 => 216788)
--- trunk/Tools/Scripts/webkitpy/port/win.py 2017-05-12 20:32:23 UTC (rev 216787)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2017-05-12 20:37:46 UTC (rev 216788)
@@ -369,6 +369,9 @@
self.restore_crash_log_saving()
super(WinPort, self).clean_up_test_run()
+ def path_to_crash_logs(self):
+ return self.results_directory()
+
def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True):
# Note that we do slow-spin here and wait, since it appears the time
# ReportCrash takes to actually write and flush the file varies when there are
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
