Title: [216774] trunk/Source/WebKit2
- Revision
- 216774
- Author
- aes...@apple.com
- Date
- 2017-05-12 12:14:06 -0700 (Fri, 12 May 2017)
Log Message
[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors
https://bugs.webkit.org/show_bug.cgi?id=172036
<rdar://problem/31587957>
Reviewed by Anders Carlsson.
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (216773 => 216774)
--- trunk/Source/WebKit2/ChangeLog 2017-05-12 19:10:18 UTC (rev 216773)
+++ trunk/Source/WebKit2/ChangeLog 2017-05-12 19:14:06 UTC (rev 216774)
@@ -1,3 +1,14 @@
+2017-05-12 Andy Estes <aes...@apple.com>
+
+ [Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors
+ https://bugs.webkit.org/show_bug.cgi?id=172036
+ <rdar://problem/31587957>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
+ (WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):
+
2017-05-12 Chris Dumez <cdu...@apple.com>
Stop using PassRefPtr under WebKit2/Shared
Modified: trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (216773 => 216774)
--- trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 19:10:18 UTC (rev 216773)
+++ trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm 2017-05-12 19:14:06 UTC (rev 216774)
@@ -785,8 +785,6 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)
auto pkShippingContactUpdate = adoptNS([allocPKPaymentRequestShippingContactUpdateInstance() initWithErrors:update ? toNSErrors(update->errors).get() : @[ ] paymentSummaryItems:m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get() shippingMethods:m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get()]);
- if ([pkShippingContactUpdate errors].count)
- [pkShippingContactUpdate setStatus:PKPaymentAuthorizationStatusFailure];
m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(pkShippingContactUpdate.get());
#else
m_paymentAuthorizationViewControllerDelegate->_didSelectShippingContactCompletion(toPKPaymentAuthorizationStatus(update), m_paymentAuthorizationViewControllerDelegate->_shippingMethods.get(), m_paymentAuthorizationViewControllerDelegate->_paymentSummaryItems.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
