Title: [213758] trunk/Source/WTF
- Revision
- 213758
- Author
- o...@webkit.org
- Date
- 2017-03-11 05:57:13 -0800 (Sat, 11 Mar 2017)
Log Message
REGRESSION(r213645): It made JSC tests super slow and timeout on AArch64 Linux
https://bugs.webkit.org/show_bug.cgi?id=169510
Unreviewed, disable LL_SC on Linux to unbreak this platform.
* wtf/Atomics.h:
* wtf/Platform.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (213757 => 213758)
--- trunk/Source/WTF/ChangeLog 2017-03-11 08:56:22 UTC (rev 213757)
+++ trunk/Source/WTF/ChangeLog 2017-03-11 13:57:13 UTC (rev 213758)
@@ -1,3 +1,13 @@
+2017-03-11 Csaba Osztrogonác <o...@webkit.org>
+
+ REGRESSION(r213645): It made JSC tests super slow and timeout on AArch64 Linux
+ https://bugs.webkit.org/show_bug.cgi?id=169510
+
+ Unreviewed, disable LL_SC on Linux to unbreak this platform.
+
+ * wtf/Atomics.h:
+ * wtf/Platform.h:
+
2017-03-10 Filip Pizlo <fpi...@apple.com>
The JITs should be able to emit fast TLS loads
@@ -4,7 +14,7 @@
https://bugs.webkit.org/show_bug.cgi?id=169483
Reviewed by Keith Miller.
-
+
Consolidated what we know about fast TLS in FastTLS.h.
* WTF.xcodeproj/project.pbxproj:
Modified: trunk/Source/WTF/wtf/Atomics.h (213757 => 213758)
--- trunk/Source/WTF/wtf/Atomics.h 2017-03-11 08:56:22 UTC (rev 213757)
+++ trunk/Source/WTF/wtf/Atomics.h 2017-03-11 13:57:13 UTC (rev 213758)
@@ -177,7 +177,7 @@
std::atomic<T> value;
};
-#if CPU(ARM64)
+#if CPU(ARM64) && HAVE(LL_SC)
#define DEFINE_LL_SC(width, modifier, suffix) \
template<> \
ALWAYS_INLINE uint ## width ## _t Atomic<uint ## width ##_t>::loadLink(std::memory_order order) \
@@ -240,7 +240,7 @@
#endif
#undef DEFINE_LL_SC
-#endif // CPU(ARM64)
+#endif // CPU(ARM64) && HAVE(LL_SC)
template<typename T>
inline T atomicLoad(T* location, std::memory_order order = std::memory_order_seq_cst)
Modified: trunk/Source/WTF/wtf/Platform.h (213757 => 213758)
--- trunk/Source/WTF/wtf/Platform.h 2017-03-11 08:56:22 UTC (rev 213757)
+++ trunk/Source/WTF/wtf/Platform.h 2017-03-11 13:57:13 UTC (rev 213758)
@@ -757,9 +757,10 @@
#define ENABLE_CONCURRENT_JS 1
#endif
-#if CPU(ARM64)
+/* FIXME: Enable it on Linux once https://bugs.webkit.org/show_bug.cgi?id=169510 is fixed. */
+#if CPU(ARM64) && OS(DARWIN)
#define HAVE_LL_SC 1
-#endif // CPU(ARM64)
+#endif // CPU(ARM64) && OS(DARWIN)
#if __has_include(<System/pthread_machdep.h>)
#define HAVE_FAST_TLS 1
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
