Title: [211740] trunk/Source/_javascript_Core
- Revision
- 211740
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-06 11:16:07 -0800 (Mon, 06 Feb 2017)
Log Message
Static Analyzer: JSContext.mm: Incorrect decrement of the reference count of an object
https://bugs.webkit.org/show_bug.cgi?id=167848
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-02-06
Reviewed by Saam Barati.
Source/_javascript_Core/API/JSContext.mm:87:5: warning: Incorrect decrement of the reference count of an object that is not owned at this point by the caller
[self.exceptionHandler release];
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
* API/JSContext.mm:
(-[JSContext dealloc]):
Use the ivar in dealloc instead of going through the getter.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSContext.mm (211739 => 211740)
--- trunk/Source/_javascript_Core/API/JSContext.mm 2017-02-06 19:13:40 UTC (rev 211739)
+++ trunk/Source/_javascript_Core/API/JSContext.mm 2017-02-06 19:16:07 UTC (rev 211740)
@@ -47,8 +47,6 @@
JSC::Strong<JSC::JSObject> m_exception;
}
-@synthesize exceptionHandler;
-
- (JSGlobalContextRef)JSGlobalContextRef
{
return m_context;
@@ -84,7 +82,7 @@
[m_wrapperMap release];
JSGlobalContextRelease(m_context);
[m_virtualMachine release];
- [self.exceptionHandler release];
+ [_exceptionHandler release];
[super dealloc];
}
Modified: trunk/Source/_javascript_Core/ChangeLog (211739 => 211740)
--- trunk/Source/_javascript_Core/ChangeLog 2017-02-06 19:13:40 UTC (rev 211739)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-02-06 19:16:07 UTC (rev 211740)
@@ -1,3 +1,19 @@
+2017-02-06 Joseph Pecoraro <pecor...@apple.com>
+
+ Static Analyzer: JSContext.mm: Incorrect decrement of the reference count of an object
+ https://bugs.webkit.org/show_bug.cgi?id=167848
+
+ Reviewed by Saam Barati.
+
+ Source/_javascript_Core/API/JSContext.mm:87:5: warning: Incorrect decrement of the reference count of an object that is not owned at this point by the caller
+ [self.exceptionHandler release];
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ 1 warning generated.
+
+ * API/JSContext.mm:
+ (-[JSContext dealloc]):
+ Use the ivar in dealloc instead of going through the getter.
+
2017-02-05 Mark Lam <mark....@apple.com>
The VMInspector should use an RAII Locker.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
