[webkit-changes] [211395] trunk

Mon, 30 Jan 2017 16:21:53 -0800

Title: [211395] trunk
Revision
211395
Author
cdu...@apple.com
Date
2017-01-30 16:22:27 -0800 (Mon, 30 Jan 2017)

Log Message

Drop legacy Attributes.isId attribute
https://bugs.webkit.org/show_bug.cgi?id=167603

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

* web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop legacy Attributes.isId attribute.

This attribute is not in the specification:
- https://dom.spec.whatwg.org/#interface-attr

Both Firefox and Chrome currently do not expose this attribute.

No new tests, rebaselined existing test.

* dom/Attr.cpp:
* dom/Attr.h:
* dom/Attr.idl:

Source/WebKit/mac:

Keep Attr.isId in ObjC bindings.

* DOM/DOMAttr.mm:
(-[DOMAttr isId]):

LayoutTests:

Drop outdated tests.

* dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
* dom/xhtml/level3/core/attrisid04.xhtml: Removed.
* dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
* dom/xhtml/level3/core/attrisid05.xhtml: Removed.
* fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
* fast/dom/Attr/change-id-via-attr-node-value.html:
* fast/dom/Element/attrisid-extra01-expected.txt: Removed.
* fast/dom/Element/attrisid-extra01.html: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (211394 => 211395)


--- trunk/LayoutTests/ChangeLog	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/ChangeLog	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,5 +1,23 @@
 2017-01-30  Chris Dumez  <cdu...@apple.com>
 
+        Drop legacy Attributes.isId attribute
+        https://bugs.webkit.org/show_bug.cgi?id=167603
+
+        Reviewed by Ryosuke Niwa.
+
+        Drop outdated tests.
+
+        * dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
+        * dom/xhtml/level3/core/attrisid04.xhtml: Removed.
+        * dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
+        * dom/xhtml/level3/core/attrisid05.xhtml: Removed.
+        * fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
+        * fast/dom/Attr/change-id-via-attr-node-value.html:
+        * fast/dom/Element/attrisid-extra01-expected.txt: Removed.
+        * fast/dom/Element/attrisid-extra01.html: Removed.
+
+2017-01-30  Chris Dumez  <cdu...@apple.com>
+
         Drop legacy constants on Event interface
         https://bugs.webkit.org/show_bug.cgi?id=167602

Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt (211394 => 211395)


--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,2 +0,0 @@
-Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/attrisid04
-Status	Success

Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml (211394 => 211395)


--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,73 +0,0 @@
-<?xml version="1.0"?><?TEST-STYLE PIDATA?>
-<!DOCTYPE html
-   PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
-   "xhtml1-strict.dtd" [
-   <!ENTITY alpha "&#945;">
-   <!ENTITY beta "&#946;">
-   <!ENTITY gamma "&#947;">
-   <!ENTITY delta "&#948;">
-   <!ENTITY epsilon "&#949;">
-   <!ENTITY alpha "&#950;">
-   <!NOTATION notation1 PUBLIC "notation1File">
-   <!NOTATION notation2 SYSTEM "notation2File">
-   <!ATTLIST p
-        dir CDATA 'rtl'
-        xmlns:dmstc CDATA #IMPLIED
-        xmlns:nm CDATA #IMPLIED
-        xmlns:emp2 CDATA #IMPLIED>
-   <!ATTLIST html
-                   xmlns:xsi CDATA #IMPLIED
-                   xsi:schemaLocation CDATA #IMPLIED>
-   <!ATTLIST acronym xsi:noNamespaceSchemaLocation CDATA #IMPLIED>
-   <!ENTITY ent4 "<span xmlns='http://www.w3.org/1999/xhtml'>Element data</span><?PItarget PIdata?>">
-   <!ATTLIST span xmlns CDATA #IMPLIED>
-]>
-<!-- This is comment number 1.-->
-<html xmlns='http://www.w3.org/1999/xhtml'
-        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/_javascript_" src="" charset="UTF-8" type="text/_javascript_" src="" type='text/_javascript_'>function loadComplete() { startTest(); }</script></head><body _onload_="loadComplete()">
- <p xmlns:dmstc="http://www.usa.com">
-  <em>EMP0001</em>
-  <strong>Margaret Martin</strong>
-  <code>Accountant</code>
-  <sup>56,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" xsi:noNamespaceSchemaLocation="Yes">1230 North Ave. Dallas, Texas 98551</acronym>
- </p>
- <p xmlns:dmstc="http://www.usa.com">
-  <em>EMP0002</em>
-  <strong>Martha Raynolds
-<![CDATA[This is a CDATASection with EntityReference number 2 &ent2;]]>
-<![CDATA[This is an adjacent CDATASection with a reference to a tab &tab;]]></strong>
-  <code>Secretary</code>
-  <sup>35,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">&beta; Dallas, &gamma;
- 98554</acronym>
- </p>
- <p xmlns:dmstc="http://www.netzero.com">
-  <em>EMP0003</em>
-  <strong>Roger
- Jones</strong>
-  <code>Department Manager</code>
-  <sup>100,000</sup>
-  <var>&ent4;</var>
-  <acronym title="Yes" class="No" id="_98553" xsi:noNamespaceSchemaLocation="Yes">PO Box 27 Irving, texas 98553</acronym>
- </p>
- <p xmlns:nm="http://www.altavista.com">
-  <em>EMP0004</em>
-  <strong>Jeny Oconnor</strong>
-  <code>Personnel Director</code>
-  <sup>95,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" class="Y&alpha;" id="_98556" xsi:noNamespaceSchemaLocation="Yes">27 South Road. Dallas, Texas 98556</acronym>
- </p>
- <p xmlns:emp2="http://www.nist.gov">
-  <em>EMP0005</em>
-  <strong>Robert Myers</strong>
-  <code>Computer Specialist</code>
-  <sup>90,000</sup>
-  <var>male</var>
-  <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">1821 Nordic. Road, Irving Texas 98558</acronym>
- </p>
-</body></html>

Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt (211394 => 211395)


--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,2 +0,0 @@
-Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/attrisid05
-Status	Success

Deleted: trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml (211394 => 211395)


--- trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,73 +0,0 @@
-<?xml version="1.0"?><?TEST-STYLE PIDATA?>
-<!DOCTYPE html
-   PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
-   "xhtml1-strict.dtd" [
-   <!ENTITY alpha "&#945;">
-   <!ENTITY beta "&#946;">
-   <!ENTITY gamma "&#947;">
-   <!ENTITY delta "&#948;">
-   <!ENTITY epsilon "&#949;">
-   <!ENTITY alpha "&#950;">
-   <!NOTATION notation1 PUBLIC "notation1File">
-   <!NOTATION notation2 SYSTEM "notation2File">
-   <!ATTLIST p
-        dir CDATA 'rtl'
-        xmlns:dmstc CDATA #IMPLIED
-        xmlns:nm CDATA #IMPLIED
-        xmlns:emp2 CDATA #IMPLIED>
-   <!ATTLIST html
-                   xmlns:xsi CDATA #IMPLIED
-                   xsi:schemaLocation CDATA #IMPLIED>
-   <!ATTLIST acronym xsi:noNamespaceSchemaLocation CDATA #IMPLIED>
-   <!ENTITY ent4 "<span xmlns='http://www.w3.org/1999/xhtml'>Element data</span><?PItarget PIdata?>">
-   <!ATTLIST span xmlns CDATA #IMPLIED>
-]>
-<!-- This is comment number 1.-->
-<html xmlns='http://www.w3.org/1999/xhtml'
-        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/_javascript_" src="" charset="UTF-8" type="text/_javascript_" src="" type='text/_javascript_'>function loadComplete() { startTest(); }</script></head><body _onload_="loadComplete()">
- <p xmlns:dmstc="http://www.usa.com">
-  <em>EMP0001</em>
-  <strong>Margaret Martin</strong>
-  <code>Accountant</code>
-  <sup>56,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" xsi:noNamespaceSchemaLocation="Yes">1230 North Ave. Dallas, Texas 98551</acronym>
- </p>
- <p xmlns:dmstc="http://www.usa.com">
-  <em>EMP0002</em>
-  <strong>Martha Raynolds
-<![CDATA[This is a CDATASection with EntityReference number 2 &ent2;]]>
-<![CDATA[This is an adjacent CDATASection with a reference to a tab &tab;]]></strong>
-  <code>Secretary</code>
-  <sup>35,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">&beta; Dallas, &gamma;
- 98554</acronym>
- </p>
- <p xmlns:dmstc="http://www.netzero.com">
-  <em>EMP0003</em>
-  <strong>Roger
- Jones</strong>
-  <code>Department Manager</code>
-  <sup>100,000</sup>
-  <var>&ent4;</var>
-  <acronym title="Yes" class="No" id="_98553" xsi:noNamespaceSchemaLocation="Yes">PO Box 27 Irving, texas 98553</acronym>
- </p>
- <p xmlns:nm="http://www.altavista.com">
-  <em>EMP0004</em>
-  <strong>Jeny Oconnor</strong>
-  <code>Personnel Director</code>
-  <sup>95,000</sup>
-  <var>Female</var>
-  <acronym title="Yes" class="Y&alpha;" id="_98556" xsi:noNamespaceSchemaLocation="Yes">27 South Road. Dallas, Texas 98556</acronym>
- </p>
- <p xmlns:emp2="http://www.nist.gov">
-  <em>EMP0005</em>
-  <strong>Robert Myers</strong>
-  <code>Computer Specialist</code>
-  <sup>90,000</sup>
-  <var>male</var>
-  <acronym title="Yes" class="Yes" xsi:noNamespaceSchemaLocation="Yes">1821 Nordic. Road, Irving Texas 98558</acronym>
- </p>
-</body></html>

Modified: trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt (211394 => 211395)


--- trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt	2017-01-31 00:22:27 UTC (rev 211395)
@@ -7,7 +7,6 @@
 1. Check id after parsing.
 PASS document.getElementById("a") is document.body
 PASS document.body.id is "a"
-PASS document.body.getAttributeNode("id").isId is true
 PASS document.body.getAttributeNode("id").textContent is "a"
 
 2. Change Attr.value.

Modified: trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html (211394 => 211395)


--- trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html	2017-01-31 00:22:27 UTC (rev 211395)
@@ -11,7 +11,6 @@
 debug("\n1. Check id after parsing.");
 shouldBe('document.getElementById("a")', 'document.body');
 shouldBe('document.body.id', '"a"');
-shouldBe('document.body.getAttributeNode("id").isId', 'true');
 shouldBe('document.body.getAttributeNode("id").textContent', '"a"');
 
 debug("\n2. Change Attr.value.");

Deleted: trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt (211394 => 211395)


--- trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,11 +0,0 @@
-Test Attr.isId where Attr is created without element.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS attr.isId is false
-PASS attr.isId is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Deleted: trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html (211394 => 211395)


--- trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/fast/dom/Element/attrisid-extra01.html	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,18 +0,0 @@
-<html>
-<head>
-<script src=""
-</head>
-<body>
-
-<script>
-description("Test Attr.isId where Attr is created without element.");
-    
-var attr = document.createAttributeNS("http://www.w3.org/XML/1998/namespace","xml:lang");
-shouldBeFalse('attr.isId');
-
-var attr = document.createAttributeNS("","id");
-shouldBeTrue('attr.isId');
-</script>
-<script src=""
-</body>
-</html>

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (211394 => 211395)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,5 +1,16 @@
 2017-01-30  Chris Dumez  <cdu...@apple.com>
 
+        Drop legacy Attributes.isId attribute
+        https://bugs.webkit.org/show_bug.cgi?id=167603
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that one more check is passing.
+
+        * web-platform-tests/dom/historical-expected.txt:
+
+2017-01-30  Chris Dumez  <cdu...@apple.com>
+
         Drop legacy constants on Event interface
         https://bugs.webkit.org/show_bug.cgi?id=167602

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (211394 => 211395)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt	2017-01-31 00:22:27 UTC (rev 211395)
@@ -37,7 +37,7 @@
 PASS Historical DOM features must be removed: setIdAttributeNS 
 PASS Historical DOM features must be removed: setIdAttributeNode 
 PASS Attr member must be nuked: schemaTypeInfo 
-FAIL Attr member must be nuked: isId assert_equals: expected (undefined) undefined but got (boolean) false
+PASS Attr member must be nuked: isId 
 PASS DocumentType member must be nuked: entities 
 PASS DocumentType member must be nuked: notations 
 PASS DocumentType member must be nuked: internalSubset

Modified: trunk/Source/WebCore/ChangeLog (211394 => 211395)


--- trunk/Source/WebCore/ChangeLog	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/ChangeLog	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,3 +1,23 @@
+2017-01-30  Chris Dumez  <cdu...@apple.com>
+
+        Drop legacy Attributes.isId attribute
+        https://bugs.webkit.org/show_bug.cgi?id=167603
+
+        Reviewed by Ryosuke Niwa.
+
+        Drop legacy Attributes.isId attribute.
+
+        This attribute is not in the specification:
+        - https://dom.spec.whatwg.org/#interface-attr
+
+        Both Firefox and Chrome currently do not expose this attribute.
+
+        No new tests, rebaselined existing test.
+
+        * dom/Attr.cpp:
+        * dom/Attr.h:
+        * dom/Attr.idl:
+
 2017-01-30  Zalan Bujtas  <za...@apple.com>
 
         Simple line layout: Small tweaks to improve performance.

Modified: trunk/Source/WebCore/dom/Attr.cpp (211394 => 211395)


--- trunk/Source/WebCore/dom/Attr.cpp	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.cpp	2017-01-31 00:22:27 UTC (rev 211395)
@@ -171,11 +171,6 @@
         m_element->attributeChanged(qualifiedName(), oldValue, newValue);
 }
 
-bool Attr::isId() const
-{
-    return qualifiedName().matches(HTMLNames::idAttr);
-}
-
 CSSStyleDeclaration* Attr::style()
 {
     // This function only exists to support the Obj-C bindings.

Modified: trunk/Source/WebCore/dom/Attr.h (211394 => 211395)


--- trunk/Source/WebCore/dom/Attr.h	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.h	2017-01-31 00:22:27 UTC (rev 211395)
@@ -56,8 +56,6 @@
 
     const QualifiedName& qualifiedName() const { return m_name; }
 
-    WEBCORE_EXPORT bool isId() const;
-
     WEBCORE_EXPORT CSSStyleDeclaration* style();
 
     void attachToElement(Element&);

Modified: trunk/Source/WebCore/dom/Attr.idl (211394 => 211395)


--- trunk/Source/WebCore/dom/Attr.idl	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebCore/dom/Attr.idl	2017-01-31 00:22:27 UTC (rev 211395)
@@ -31,8 +31,6 @@
 
     readonly attribute Element ownerElement;
 
-    readonly attribute boolean isId;
-
     readonly attribute DOMString? namespaceURI;
     readonly attribute DOMString? prefix;
     readonly attribute DOMString localName;

Modified: trunk/Source/WebKit/mac/ChangeLog (211394 => 211395)


--- trunk/Source/WebKit/mac/ChangeLog	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-01-31 00:22:27 UTC (rev 211395)
@@ -1,3 +1,15 @@
+2017-01-30  Chris Dumez  <cdu...@apple.com>
+
+        Drop legacy Attributes.isId attribute
+        https://bugs.webkit.org/show_bug.cgi?id=167603
+
+        Reviewed by Ryosuke Niwa.
+
+        Keep Attr.isId in ObjC bindings.
+
+        * DOM/DOMAttr.mm:
+        (-[DOMAttr isId]):
+
 2017-01-30  Andreas Kling  <akl...@apple.com>
 
         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.

Modified: trunk/Source/WebKit/mac/DOM/DOMAttr.mm (211394 => 211395)


--- trunk/Source/WebKit/mac/DOM/DOMAttr.mm	2017-01-31 00:17:04 UTC (rev 211394)
+++ trunk/Source/WebKit/mac/DOM/DOMAttr.mm	2017-01-31 00:22:27 UTC (rev 211395)
@@ -76,7 +76,7 @@
 - (BOOL)isId
 {
     WebCore::JSMainThreadNullState state;
-    return IMPL->isId();
+    return IMPL->qualifiedName().matches(WebCore::HTMLNames::idAttr);
 }
 
 - (DOMCSSStyleDeclaration *)style

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to