Title: [98927] trunk/Tools
Revision
98927
Author
[email protected]
Date
2011-10-31 17:50:44 -0700 (Mon, 31 Oct 2011)

Log Message

Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT

Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js (98926 => 98927)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js	2011-11-01 00:43:49 UTC (rev 98926)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js	2011-11-01 00:50:44 UTC (rev 98927)
@@ -50,7 +50,7 @@
                             continue;
                         var strings = step.text;
                         for (var stringIndex = 0; stringIndex < strings.length; ++stringIndex) {
-                            var match = /^(\d+) total leaks found!$/.exec(strings[stringIndex]);
+                            var match = /^(\d+) total leaks found/.exec(strings[stringIndex]);
                             if (!match)
                                 continue;
                             buildInfo.leakCount = parseInt(match[1], 10);

Modified: trunk/Tools/ChangeLog (98926 => 98927)


--- trunk/Tools/ChangeLog	2011-11-01 00:43:49 UTC (rev 98926)
+++ trunk/Tools/ChangeLog	2011-11-01 00:50:44 UTC (rev 98927)
@@ -1,3 +1,17 @@
+2011-10-31  Adam Roben  <[email protected]>
+
+        Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
+
+        Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
+        leaky builds
+
+        Reviewed by Anders Carlsson.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
+        (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
+        NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
+        total of N bytes!").
+
 2011-10-31  Raphael Kubo da Costa  <[email protected]>
 
         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to