Title: [209379] trunk/Source/WebCore
Revision
209379
Author
rmonde...@apple.com
Date
2016-12-05 19:30:07 -0800 (Mon, 05 Dec 2016)

Log Message

STP 19 fails to launch on 16B255
https://bugs.webkit.org/show_bug.cgi?id=165388
-and corresponding-
rdar://problem/29514476

Reviewed by Tim Horton.

* platform/spi/cocoa/NSTouchBarSPI.h: Re-declare the SPI symbols as weak. The cited crash itself is for a
    symbol we weren't handling here, but is part of the same group. Re-declare all four of these symbols to
    be safe.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209378 => 209379)


--- trunk/Source/WebCore/ChangeLog	2016-12-06 03:14:54 UTC (rev 209378)
+++ trunk/Source/WebCore/ChangeLog	2016-12-06 03:30:07 UTC (rev 209379)
@@ -1,3 +1,16 @@
+2016-12-05  Ricky Mondello  <rmonde...@apple.com>
+
+        STP 19 fails to launch on 16B255
+        https://bugs.webkit.org/show_bug.cgi?id=165388
+        -and corresponding-
+        rdar://problem/29514476
+
+        Reviewed by Tim Horton.
+
+        * platform/spi/cocoa/NSTouchBarSPI.h: Re-declare the SPI symbols as weak. The cited crash itself is for a
+            symbol we weren't handling here, but is part of the same group. Re-declare all four of these symbols to
+            be safe.
+
 2016-12-05  Antoine Quint  <grao...@apple.com>
 
         ERROR: post-layout: dirty renderer(s) - Encountered with LayoutTest media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html

Modified: trunk/Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h (209378 => 209379)


--- trunk/Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h	2016-12-06 03:14:54 UTC (rev 209378)
+++ trunk/Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h	2016-12-06 03:30:07 UTC (rev 209379)
@@ -51,10 +51,13 @@
 
 @end
 
-#define NSTouchBarWillEnterCustomization @"NSTouchBarWillEnterCustomization"
-#define NSTouchBarWillExitCustomization @"NSTouchBarWillExitCustomization"
-
 NS_ASSUME_NONNULL_END
 
 #endif // USE(APPLE_INTERNAL_SDK)
+
+APPKIT_EXTERN NSNotificationName const NSTouchBarWillEnterCustomization API_AVAILABLE(macosx(10.12.2));
+APPKIT_EXTERN NSNotificationName const NSTouchBarDidEnterCustomization API_AVAILABLE(macosx(10.12.2));
+APPKIT_EXTERN NSNotificationName const NSTouchBarWillExitCustomization API_AVAILABLE(macosx(10.12.2));
+APPKIT_EXTERN NSNotificationName const NSTouchBarDidExitCustomization API_AVAILABLE(macosx(10.12.2));
+
 #endif // PLATFORM(MAC) && HAVE(TOUCH_BAR)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to