Title: [209319] trunk/Source/WebCore
Revision
209319
Author
hy...@apple.com
Date
2016-12-05 09:28:23 -0800 (Mon, 05 Dec 2016)

Log Message

[CSS Parser] Don't use CSS_PARSER_INTEGER unit for resolved integer calcs.
https://bugs.webkit.org/show_bug.cgi?id=165379

Reviewed by Dean Jackson.

* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209318 => 209319)


--- trunk/Source/WebCore/ChangeLog	2016-12-05 17:13:42 UTC (rev 209318)
+++ trunk/Source/WebCore/ChangeLog	2016-12-05 17:28:23 UTC (rev 209319)
@@ -1,5 +1,15 @@
 2016-12-05  Dave Hyatt  <hy...@apple.com>
 
+        [CSS Parser] Don't use CSS_PARSER_INTEGER unit for resolved integer calcs.
+        https://bugs.webkit.org/show_bug.cgi?id=165379
+
+        Reviewed by Dean Jackson.
+
+        * css/parser/CSSPropertyParserHelpers.cpp:
+        (WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):
+
+2016-12-05  Dave Hyatt  <hy...@apple.com>
+
         [CSS Parser] Add parseValue support to new parser. Use new parser for UA sheet too if useNewParser is set.
         https://bugs.webkit.org/show_bug.cgi?id=165376
 

Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (209318 => 209319)


--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-12-05 17:13:42 UTC (rev 209318)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-12-05 17:28:23 UTC (rev 209319)
@@ -100,8 +100,7 @@
         if (!m_calcValue)
             return nullptr;
         m_sourceRange = m_range;
-        CSSPrimitiveValue::UnitTypes unitType = m_calcValue->isInt() ? CSSPrimitiveValue::UnitTypes::CSS_PARSER_INTEGER : CSSPrimitiveValue::UnitTypes::CSS_NUMBER;
-        return CSSValuePool::singleton().createValue(m_calcValue->doubleValue(), unitType);
+        return CSSValuePool::singleton().createValue(m_calcValue->doubleValue(), CSSPrimitiveValue::UnitTypes::CSS_NUMBER);
     }
 
     bool consumeNumberRaw(double& result)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to