Title: [208464] trunk/Source/WebCore
- Revision
- 208464
- Author
- jer.no...@apple.com
- Date
- 2016-11-09 12:18:46 -0800 (Wed, 09 Nov 2016)
Log Message
REGRESSION (r208149): Media scrubber is not displayed in media controls
https://bugs.webkit.org/show_bug.cgi?id=164514
Reviewed by Darin Adler.
Fixes broken Media Controls API tests.
Added a new PlatformMediaSessionType; need to add that same type to the TYPE_TRAITS section of
MediaElementSession.h so that is<> and downcast<> work correctly.
* html/MediaElementSession.h:
(isType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (208463 => 208464)
--- trunk/Source/WebCore/ChangeLog 2016-11-09 20:13:11 UTC (rev 208463)
+++ trunk/Source/WebCore/ChangeLog 2016-11-09 20:18:46 UTC (rev 208464)
@@ -1,3 +1,18 @@
+2016-11-09 Jer Noble <jer.no...@apple.com>
+
+ REGRESSION (r208149): Media scrubber is not displayed in media controls
+ https://bugs.webkit.org/show_bug.cgi?id=164514
+
+ Reviewed by Darin Adler.
+
+ Fixes broken Media Controls API tests.
+
+ Added a new PlatformMediaSessionType; need to add that same type to the TYPE_TRAITS section of
+ MediaElementSession.h so that is<> and downcast<> work correctly.
+
+ * html/MediaElementSession.h:
+ (isType):
+
2016-11-09 Wenson Hsieh <wenson_hs...@apple.com>
When editing IME, `compositionend` events should fire after input events
Modified: trunk/Source/WebCore/html/MediaElementSession.h (208463 => 208464)
--- trunk/Source/WebCore/html/MediaElementSession.h 2016-11-09 20:13:11 UTC (rev 208463)
+++ trunk/Source/WebCore/html/MediaElementSession.h 2016-11-09 20:18:46 UTC (rev 208464)
@@ -127,6 +127,13 @@
bool allowsPlaybackControlsForAutoplayingAudio() const;
bool allowsNowPlayingControlsVisibility() const override;
+ static bool isMediaElementSessionMediaType(MediaType type)
+ {
+ return type == Video
+ || type == Audio
+ || type == VideoAudio;
+ }
+
private:
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
@@ -165,7 +172,7 @@
} // namespace WebCore
SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::MediaElementSession)
-static bool isType(const WebCore::PlatformMediaSession& session) { return session.mediaType() == WebCore::PlatformMediaSession::Video || session.mediaType() == WebCore::PlatformMediaSession::Audio; }
+static bool isType(const WebCore::PlatformMediaSession& session) { return WebCore::MediaElementSession::isMediaElementSessionMediaType(session.mediaType()); }
SPECIALIZE_TYPE_TRAITS_END()
#endif // ENABLE(VIDEO)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
