Title: [98716] trunk
- Revision
- 98716
- Author
- [email protected]
- Date
- 2011-10-28 04:47:47 -0700 (Fri, 28 Oct 2011)
Log Message
[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
https://bugs.webkit.org/show_bug.cgi?id=71019
Source/WebCore:
Reviewed by Andreas Kling.
These properties need to be marked inherited too.
Note that the new test case doesn't fail even without the patch. If I understand correctly
the image test in the title is pretty much the only way to see this. However the
new test improves code coverage and protects against future regressions.
Test: fast/css/inherited-properties-rare-text.html
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
LayoutTests:
Reviewed by Andreas Kling.
* fast/css/inherited-properties-rare-text-expected.txt: Added.
* fast/css/inherited-properties-rare-text.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98715 => 98716)
--- trunk/LayoutTests/ChangeLog 2011-10-28 09:52:28 UTC (rev 98715)
+++ trunk/LayoutTests/ChangeLog 2011-10-28 11:47:47 UTC (rev 98716)
@@ -1,3 +1,13 @@
+2011-10-28 Antti Koivisto <[email protected]>
+
+ [Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
+ https://bugs.webkit.org/show_bug.cgi?id=71019
+
+ Reviewed by Andreas Kling.
+
+ * fast/css/inherited-properties-rare-text-expected.txt: Added.
+ * fast/css/inherited-properties-rare-text.html: Added.
+
2011-10-19 Alexander Pavlov <[email protected]>
Web Inspector: CSS background-image applied inline shows a warning, but still works.
Added: trunk/LayoutTests/fast/css/inherited-properties-rare-text-expected.txt (0 => 98716)
--- trunk/LayoutTests/fast/css/inherited-properties-rare-text-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/inherited-properties-rare-text-expected.txt 2011-10-28 11:47:47 UTC (rev 98716)
@@ -0,0 +1,7 @@
+test1 -webkit-font-feature-settings: 'dlig' 1
+test2 -webkit-font-feature-settings: normal
+test1 -webkit-font-smoothing: antialiased
+test2 -webkit-font-smoothing: auto
+test1 -webkit-text-orientation: upright
+test2 -webkit-text-orientation: vertical-right
+
Added: trunk/LayoutTests/fast/css/inherited-properties-rare-text.html (0 => 98716)
--- trunk/LayoutTests/fast/css/inherited-properties-rare-text.html (rev 0)
+++ trunk/LayoutTests/fast/css/inherited-properties-rare-text.html 2011-10-28 11:47:47 UTC (rev 98716)
@@ -0,0 +1,25 @@
+<script>
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+<style>
+.a { -webkit-font-feature-settings: 'dlig'; -webkit-font-smoothing: antialiased; -webkit-text-orientation: upright; }
+</style>
+<div class=a>
+ <div id=test1></div>
+</div>
+<div id=test2></div>
+<script>
+function test(e, p) {
+ var testDiv = document.getElementById(e);
+ var cssValue = window.getComputedStyle(testDiv).getPropertyCSSValue(p);
+ document.write(e + " " + p + ": " + cssValue.cssText + "<br>");
+}
+
+test('test1', '-webkit-font-feature-settings');
+test('test2', '-webkit-font-feature-settings');
+test('test1', '-webkit-font-smoothing');
+test('test2', '-webkit-font-smoothing');
+test('test1', '-webkit-text-orientation');
+test('test2', '-webkit-text-orientation');
+</script>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (98715 => 98716)
--- trunk/Source/WebCore/ChangeLog 2011-10-28 09:52:28 UTC (rev 98715)
+++ trunk/Source/WebCore/ChangeLog 2011-10-28 11:47:47 UTC (rev 98716)
@@ -1,3 +1,21 @@
+2011-10-28 Antti Koivisto <[email protected]>
+
+ [Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
+ https://bugs.webkit.org/show_bug.cgi?id=71019
+
+ Reviewed by Andreas Kling.
+
+ These properties need to be marked inherited too.
+
+ Note that the new test case doesn't fail even without the patch. If I understand correctly
+ the image test in the title is pretty much the only way to see this. However the
+ new test improves code coverage and protects against future regressions.
+
+ Test: fast/css/inherited-properties-rare-text.html
+
+ * css/CSSProperty.cpp:
+ (WebCore::CSSProperty::isInheritedProperty):
+
2011-10-28 Adam Barth <[email protected]>
Remove getExceptionCodeDescription()
Modified: trunk/Source/WebCore/css/CSSProperty.cpp (98715 => 98716)
--- trunk/Source/WebCore/css/CSSProperty.cpp 2011-10-28 09:52:28 UTC (rev 98715)
+++ trunk/Source/WebCore/css/CSSProperty.cpp 2011-10-28 11:47:47 UTC (rev 98716)
@@ -321,6 +321,8 @@
case CSSPropertyWebkitBorderVerticalSpacing:
case CSSPropertyWebkitBoxDirection:
case CSSPropertyWebkitColorCorrection:
+ case CSSPropertyWebkitFontFeatureSettings:
+ case CSSPropertyWebkitFontSmoothing:
case CSSPropertyWebkitLocale:
case CSSPropertyWebkitHighlight:
case CSSPropertyWebkitHyphenateCharacter:
@@ -340,6 +342,7 @@
case CSSPropertyWebkitTextEmphasisPosition:
case CSSPropertyWebkitTextEmphasisStyle:
case CSSPropertyWebkitTextFillColor:
+ case CSSPropertyWebkitTextOrientation:
case CSSPropertyWebkitTextSecurity:
case CSSPropertyWebkitTextSizeAdjust:
case CSSPropertyWebkitTextStroke:
@@ -385,9 +388,6 @@
#endif
return true;
case CSSPropertyDisplay:
- case CSSPropertyWebkitFontFeatureSettings:
- case CSSPropertyWebkitFontSmoothing:
- case CSSPropertyWebkitTextOrientation:
case CSSPropertyZoom:
case CSSPropertyBackground:
case CSSPropertyBackgroundAttachment:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
