Title: [208088] trunk/Source/WebCore
Revision
208088
Author
hy...@apple.com
Date
2016-10-28 17:28:15 -0700 (Fri, 28 Oct 2016)

Log Message

[CSS Parser] Allow unknown properties in will-change
https://bugs.webkit.org/show_bug.cgi?id=164165

Reviewed by Simon Fraser.

* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeWillChange):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (208087 => 208088)


--- trunk/Source/WebCore/ChangeLog	2016-10-29 00:20:38 UTC (rev 208087)
+++ trunk/Source/WebCore/ChangeLog	2016-10-29 00:28:15 UTC (rev 208088)
@@ -1,3 +1,13 @@
+2016-10-28  Dave Hyatt  <hy...@apple.com>
+
+        [CSS Parser] Allow unknown properties in will-change
+        https://bugs.webkit.org/show_bug.cgi?id=164165
+
+        Reviewed by Simon Fraser.
+
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::consumeWillChange):
+
 2016-10-28  Alex Christensen  <achristen...@webkit.org>
 
         Partially revert 207805 after resolution in URL spec issue 87

Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (208087 => 208088)


--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-29 00:20:38 UTC (rev 208087)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp	2016-10-29 00:28:15 UTC (rev 208088)
@@ -393,7 +393,8 @@
             // Need to return nullptr when currentValue is CSSPropertyAll.
             if (propertyID == CSSPropertyWillChange || propertyID == CSSPropertyAll)
                 return nullptr;
-            values->append(CSSCustomIdentValue::create(propertyID));
+            // FIXME-NEWPARSER: Use CSSCustomIdentValue someday.
+            values->append(CSSValuePool::singleton().createIdentifierValue(propertyID));
             range.consumeIncludingWhitespace();
         } else {
             switch (range.peek().id()) {
@@ -409,7 +410,8 @@
                 values->append(consumeIdent(range).releaseNonNull());
                 break;
             default:
-                range.consumeIncludingWhitespace();
+                // Append properties we don't recognize, but that are legal, as strings.
+                values->append(consumeCustomIdent(range).releaseNonNull());
                 break;
             }
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to