Title: [206825] trunk/Source/WebCore
Revision
206825
Author
mcatanz...@igalia.com
Date
2016-10-05 13:20:02 -0700 (Wed, 05 Oct 2016)

Log Message

[GTK] Improve comment in platformVersionForUAString
https://bugs.webkit.org/show_bug.cgi?id=162612

Reviewed by Carlos Garcia Campos.

* platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (206824 => 206825)


--- trunk/Source/WebCore/ChangeLog	2016-10-05 19:02:57 UTC (rev 206824)
+++ trunk/Source/WebCore/ChangeLog	2016-10-05 20:20:02 UTC (rev 206825)
@@ -1,3 +1,13 @@
+2016-10-05  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        [GTK] Improve comment in platformVersionForUAString
+        https://bugs.webkit.org/show_bug.cgi?id=162612
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/gtk/UserAgentGtk.cpp:
+        (WebCore::platformVersionForUAString):
+
 2016-10-05  Zalan Bujtas  <za...@apple.com>
 
         Missing quotation mark when <q> gets reparented.

Modified: trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp (206824 => 206825)


--- trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2016-10-05 19:02:57 UTC (rev 206824)
+++ trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2016-10-05 20:20:02 UTC (rev 206825)
@@ -94,8 +94,10 @@
     static NeverDestroyed<const String> uaOSVersion(String::format("%s %s", name.sysname, name.machine));
     return uaOSVersion;
 #else
-    // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites.
-    // And we always claim to be Intel since ARM triggers mobile versions of some websites.
+    // We will always claim to be Safari in Intel Mac OS X, since Safari without
+    // OS X or anything on ARM triggers mobile versions of some websites.
+    //
+    // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4".
     static NeverDestroyed<const String> uaOSVersion(ASCIILiteral("Intel Mac OS X"));
     return uaOSVersion;
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to