Title: [206335] trunk/Tools
- Revision
- 206335
- Author
- wenson_hs...@apple.com
- Date
- 2016-09-23 15:54:39 -0700 (Fri, 23 Sep 2016)
Log Message
[mac-sierra] 2 WKWebViewCandidateTests API test failures
https://bugs.webkit.org/show_bug.cgi?id=162470
Reviewed by Tim Horton.
VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
tests with an SDK check to prevent 10.12.0 bots from building them.
* TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
* TestWebKitAPI/Tests/mac/CandidateTests.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (206334 => 206335)
--- trunk/Tools/ChangeLog 2016-09-23 22:32:28 UTC (rev 206334)
+++ trunk/Tools/ChangeLog 2016-09-23 22:54:39 UTC (rev 206335)
@@ -1,3 +1,17 @@
+2016-09-23 Wenson Hsieh <wenson_hs...@apple.com>
+
+ [mac-sierra] 2 WKWebViewCandidateTests API test failures
+ https://bugs.webkit.org/show_bug.cgi?id=162470
+
+ Reviewed by Tim Horton.
+
+ VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
+ tests with an SDK check to prevent 10.12.0 bots from building them.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
+ * TestWebKitAPI/Tests/mac/CandidateTests.mm:
+
2016-09-23 Alex Christensen <achristen...@webkit.org>
Refactor URLParser
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm (206334 => 206335)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm 2016-09-23 22:32:28 UTC (rev 206334)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm 2016-09-23 22:54:39 UTC (rev 206335)
@@ -32,7 +32,7 @@
#import <WebKit/WKWebViewPrivate.h>
#import <wtf/RetainPtr.h>
-#if WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201
@interface WKWebView (WKWebViewAdditions)
@@ -412,4 +412,4 @@
} // namespace TestWebKitAPI
-#endif // WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#endif // WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm (206334 => 206335)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm 2016-09-23 22:32:28 UTC (rev 206334)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm 2016-09-23 22:54:39 UTC (rev 206335)
@@ -25,7 +25,7 @@
#import "config.h"
-#if WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201
#import "PlatformUtilities.h"
#import "TestWKWebViewMac.h"
@@ -243,4 +243,4 @@
#endif
-#endif /* WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 */
+#endif /* WK_API_ENABLED && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201 */
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm (206334 => 206335)
--- trunk/Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm 2016-09-23 22:32:28 UTC (rev 206334)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm 2016-09-23 22:54:39 UTC (rev 206335)
@@ -29,7 +29,7 @@
#import <WebKit/WebViewPrivate.h>
#import <wtf/RetainPtr.h>
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201
static bool webViewWasDeallocated = false;
static bool didFinishLoad = false;
@@ -145,4 +145,4 @@
}
-#endif // PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#endif // PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
