Title: [98421] trunk
- Revision
- 98421
- Author
- [email protected]
- Date
- 2011-10-25 18:45:40 -0700 (Tue, 25 Oct 2011)
Log Message
AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856
Reviewed by Darin Adler.
Source/WebCore:
Test: platform/mac/accessibility/slider-allows-title-ui-element.html
* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::isControl):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
* platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
* platform/mac/accessibility/slider-allows-title-ui-element.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98420 => 98421)
--- trunk/LayoutTests/ChangeLog 2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/LayoutTests/ChangeLog 2011-10-26 01:45:40 UTC (rev 98421)
@@ -1,3 +1,13 @@
+2011-10-25 Chris Fleizach <[email protected]>
+
+ AX: WebKit does not expose HTML label for slider elements
+ https://bugs.webkit.org/show_bug.cgi?id=70856
+
+ Reviewed by Darin Adler.
+
+ * platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
+ * platform/mac/accessibility/slider-allows-title-ui-element.html: Added.
+
2011-10-25 Julien Chaffraix <[email protected]>
Unreviewed gardening.
Added: trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt (0 => 98421)
--- trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt 2011-10-26 01:45:40 UTC (rev 98421)
@@ -0,0 +1,13 @@
+Color:
+This tests that sliders are allowed to have title UI elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS slider.titleUIElement().isEqual(title) is true
+PASS title.role is 'AXRole: AXGroup'
+PASS title.childAtIndex(0).role is 'AXRole: AXStaticText'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html (0 => 98421)
--- trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html 2011-10-26 01:45:40 UTC (rev 98421)
@@ -0,0 +1,40 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<link rel="stylesheet" href=""
+<script>
+var successfullyParsed = false;
+</script>
+<script src=""
+</head>
+<body id="body">
+
+<label for="" tabindex="0" id="title">Color:</label>
+<input id="slider" type="range" min="0" value="0" max="6">
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that sliders are allowed to have title UI elements.");
+
+ if (window.accessibilityController) {
+
+ document.getElementById("slider").focus();
+ var slider = accessibilityController.focusedElement;
+
+ document.getElementById("title").focus();
+ var title = accessibilityController.rootElement.childAtIndex(0).childAtIndex(0).childAtIndex(0);
+
+ shouldBeTrue("slider.titleUIElement().isEqual(title)");
+ shouldBe("title.role", "'AXRole: AXGroup'");
+ shouldBe("title.childAtIndex(0).role", "'AXRole: AXStaticText'");
+ }
+
+ successfullyParsed = true;
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (98420 => 98421)
--- trunk/Source/WebCore/ChangeLog 2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/Source/WebCore/ChangeLog 2011-10-26 01:45:40 UTC (rev 98421)
@@ -1,3 +1,17 @@
+2011-10-25 Chris Fleizach <[email protected]>
+
+ AX: WebKit does not expose HTML label for slider elements
+ https://bugs.webkit.org/show_bug.cgi?id=70856
+
+ Reviewed by Darin Adler.
+
+ Test: platform/mac/accessibility/slider-allows-title-ui-element.html
+
+ * accessibility/AccessibilitySlider.h:
+ (WebCore::AccessibilitySlider::isControl):
+ * accessibility/mac/WebAccessibilityObjectWrapper.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
2011-10-25 Mark Hahnenberg <[email protected]>
Remove putVirtual
Modified: trunk/Source/WebCore/accessibility/AccessibilitySlider.h (98420 => 98421)
--- trunk/Source/WebCore/accessibility/AccessibilitySlider.h 2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/Source/WebCore/accessibility/AccessibilitySlider.h 2011-10-26 01:45:40 UTC (rev 98421)
@@ -53,6 +53,7 @@
virtual AccessibilityRole roleValue() const { return SliderRole; }
virtual bool isSlider() const { return true; }
virtual bool isInputSlider() const { return true; }
+ virtual bool isControl() const { return true; }
virtual void addChildren();
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm (98420 => 98421)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2011-10-26 01:45:40 UTC (rev 98421)
@@ -1078,6 +1078,7 @@
[tempArray addObject:NSAccessibilityMaxValueAttribute];
[tempArray addObject:NSAccessibilityOrientationAttribute];
[tempArray addObject:NSAccessibilityValueDescriptionAttribute];
+ [tempArray addObject:NSAccessibilityTitleUIElementAttribute];
rangeAttrs = [[NSArray alloc] initWithArray:tempArray];
[tempArray release];
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
